Conversation
| cpanm --notest Net::Statsd | ||
| ``` | ||
|
|
||
| ## 10.2 Installation with Clickhouse |
There was a problem hiding this comment.
I suggest that we have the same model as with the other databases, per OS. In this case "currently not available" for other than Debian/Ubuntu.
| Currently there are no instructions for cleaning up a Clickhose database. | ||
|
|
There was a problem hiding this comment.
| Currently there are no instructions for cleaning up a Clickhose database. | |
| Currently there are no instructions for cleaning up a Clickhouse database. |
| [Zonemaster::LDNS]: https://github.com/zonemaster/zonemaster-ldns/blob/master/README.md | ||
|
|
||
|
|
||
| Cleaning up the database] |
There was a problem hiding this comment.
| Cleaning up the database] |
|
|
||
| ### 9.3. Clickhouse (FreeBSD) | ||
|
|
||
| There is not yet any specific installation instructions for FreeBSD. In most |
There was a problem hiding this comment.
| There is not yet any specific installation instructions for FreeBSD. In most | |
| There is no specific installation instructions for FreeBSD yet. In most | |
|
|
||
| ### 9.1. Clickhouse (Rocky Linux) | ||
|
|
||
| There is not yet any specific installation instructions for Rocky Linux. In most |
There was a problem hiding this comment.
| There is not yet any specific installation instructions for Rocky Linux. In most | |
| There is no specific installation instructions for Rocky Linux yet. In most | |
With the proposed updates from @tgreenx I am ready to approve.
tgreenx
left a comment
There was a problem hiding this comment.
A few comments after I went through here again while reviewing zonemaster/zonemaster-backend#1094
tgreenx
left a comment
There was a problem hiding this comment.
One more thing I found out when following the installation instructions on my machine.
marc-vanderwal
left a comment
There was a problem hiding this comment.
The instructions are incomplete for Rocky Linux and FreeBSD, but I’ve filled in the gaps for both operating systems. I haven’t tested the FreeBSD instructions however; only Rocky Linux.
| The [MySQL interface][Clickhouse MySQL interface]'s port the Clickhouse server | ||
| is listening on. |
There was a problem hiding this comment.
The way it’s worded can seem like it’s a typo. Can I suggest:
The port the Clickhouse server is listening on, for connections using the MySQL-compatible protocol.
| There is no specific installation instructions for Rocky Linux yet. In most | ||
| parts the instructions for Debian/Ubuntu can be followed. |
There was a problem hiding this comment.
When I read this, it feels like “sorry, I’ve couldn’t be bothered to write instructions for Rocky Linux, go figure it out on your own using that other OS’s documentation.”
Doing so means repeating oneself, that’s true, but other sections in this document also repeat the instructions with slight variations where it’s needed.
In a nutshell:
- install Clickhouse using the instructions at https://clickhouse.com/docs/en/install#from-rpm-packages;
- enable Clickhouse using the same
sedcommand as for Debian/Ubuntu; - install DBD::MySQL with the command
sudo dnf install -y perl-DBD-MySQL
| > **Note**: The Clickhouse MySQL interface requires a [double SHA1 | ||
| > password](https://clickhouse.com/docs/en/operations/settings/settings-users#password_double_sha1_hex) | ||
| > ``` | ||
| > PASSWORD=$(base64 < /dev/urandom | head -c8); echo "$PASSWORD"; echo -n "$PASSWORD" | sha1sum | tr -d '-' | xxd -r -p | sha1sum | tr -d '-' |
There was a problem hiding this comment.
Using openssl might be a bit less hacky. I also suggest avoiding echo -n:
| > PASSWORD=$(base64 < /dev/urandom | head -c8); echo "$PASSWORD"; echo -n "$PASSWORD" | sha1sum | tr -d '-' | xxd -r -p | sha1sum | tr -d '-' | |
| > PASSWORD=$(openssl rand -base64 12); echo "$PASSWORD"; printf "%s" "$PASSWORD" | openssl sha1 -binary | openssl sha1 | awk '{ print $2 }' |
There was a problem hiding this comment.
The oneliner is a copy/paste from the Clickhouse documentation.
| There is no specific installation instructions for FreeBSD yet. In most parts | ||
| the instructions for Debian/Ubuntu can be followed. |
There was a problem hiding this comment.
There is a FreeBSD port for Clickhouse, so installing it is a pkg install -y clickhouse away.
You will also need to do pkg install -y p5-DBD-MySQL and adjust the sed command so that it modifies /usr/local/etc/zonemaster/backend_config.ini instead of /etc/zonemaster/backend_config.ini.
|
Good news though: I am happy to report that Clickhouse works on Rocky Linux 9 by following the instructions, where I filled in the gaps. |
|
I updated the documentation document to integrate other OS. I've changed the section layout a little to avoid repetitions. |
matsduf
left a comment
There was a problem hiding this comment.
Just some minor comments, else it looks good.
tgreenx
left a comment
There was a problem hiding this comment.
Postponed, as the corresponding feature (zonemaster/zonemaster-backend#1094) has been postponed as well
Purpose
Document Clickhouse database engine installation and configuration for Zonemaster-Backend. This is an experimental feature.
Context
Relates to zonemaster/zonemaster-backend#1094
Changes
Add a Clickhouse section to
docs/public/installation/zonemaster-backend.mdanddocs/public/configuration/backend.md.How to test this PR
Documentation, review the changes.