Specification of test zones for CONSISTENCY05 and CONSISTENCY06#1213
Merged
Conversation
tgreenx
reviewed
Nov 20, 2023
tgreenx
left a comment
Contributor
There was a problem hiding this comment.
I get this error:
$ git log -1 --oneline
4d21b8e6 (HEAD -> test-PR1213) Corrects scenario ADDRESSES-MATCH-2 implementation
$ sudo sh set-ip.sh
set-ip.sh: 82: Syntax error: "(" unexpected (expecting "then")
Contributor
Author
The skript can be run as I will update the instructions. |
Contributor
Author
|
@tgreenx, please re-review. |
marc-vanderwal
left a comment
Contributor
There was a problem hiding this comment.
I see only style and spelling issues. Note that it’s “sibling”, not “sibbling”.
Co-authored-by: Marc van der Wal <103426270+marc-vanderwal@users.noreply.github.com>
Contributor
Author
|
@tgreenx and @marc-vanderwal, please re-review. |
Contributor
Author
|
@tgreenx and @marc-vanderwal, please re-review. |
marc-vanderwal
approved these changes
Nov 27, 2023
marc-vanderwal
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me.
tgreenx
approved these changes
Nov 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Context
Updated unit tests based on the content of this PR are found in zonemaster/zonemaster-engine#1303
How to test this PR
Review.