This repository was archived by the owner on May 7, 2024. It is now read-only.
This repository was archived by the owner on May 7, 2024. It is now read-only.
Support latest LTS node@18 or latest node #334
Description
The current implementation requires node@16: https://github.com/znck/grammarly/blob/main/package.json#L4
When starting grammarly-languageserver with node@18 or node@19, there appears a runtime error if it is attached to a markdown file:
TypeError: Failed to parse URL from /path/to/grammarly-languageserver/node_modules/web-tree-sitter/tree-sitter.wasm
at Object.fetch (node:internal/deps/undici/undici:14294:11) {
[cause]: TypeError [ERR_INVALID_URL]: Invalid URL
at new NodeError (node:internal/errors:393:5)
at URL.onParseError (node:internal/url:565:9)
at new URL (node:internal/url:645:5)
at new Request (node:internal/deps/undici/undici:7023:25)
at fetch2 (node:internal/deps/undici/undici:13460:25)
at Object.fetch (node:internal/deps/undici/undici:14292:18)
at fetch (node:internal/process/pre_execution:238:25)
at /path/to/grammarly-languageserver/node_modules/web-tree-sitter/tree-sitter.js:1:15192
at /path/to/grammarly-languageserver/node_modules/web-tree-sitter/tree-sitter.js:1:15413
at new Promise (<anonymous>) {
input: '/path/to/grammarly-languageserver/node_modules/web-tree-sitter/tree-sitter.wasm',
code: 'ERR_INVALID_URL'
}
}
It seems to be breaking change in node@18 related to URL.
Is it possible that grammarly gets updated an support the latest node?
This issue originated from Homebrew/homebrew-core#118003, which patches the grammarly-languageserver formula by sticking to node@16 and avoids this issue temporarily.