Skip to content

Always buffer private messages for replay#521

Closed
omgjlk wants to merge 1 commit intoznc:masterfrom
omgjlk:querybuffer
Closed

Always buffer private messages for replay#521
omgjlk wants to merge 1 commit intoznc:masterfrom
omgjlk:querybuffer

Conversation

@omgjlk
Copy link
Copy Markdown

@omgjlk omgjlk commented Apr 4, 2014

This is useful if connecting with multiple hosts, and want private
messages to get replayed when connecting a second(+) host, or
reconnecting the same host. To facilitate clearing the buffer, the
ClearAllBuffers command will now also clear the query buffer.

I've also updated the clearbufferonmsg module to clear query buffers on
msg as that seemed appropriate (and how I want things to work).

This is largely based on the work found at
https://gist.github.com/jreese/1206300

Tested with 1.2 release.

This is useful if connecting with multiple hosts, and want private
messages to get replayed when connecting a second(+) host, or
reconnecting the same host. To facilitate clearing the buffer, the
ClearAllBuffers command will now also clear the query buffer.

I've also updated the clearbufferonmsg module to clear query buffers on
msg as that seemed appropriate (and how I want things to work).

This is largely based on the work found at
https://gist.github.com/jreese/1206300

Tested with 1.2 release.
@md-5
Copy link
Copy Markdown
Contributor

md-5 commented Apr 4, 2014

Yes, yes, yes!

@DarthGandalf
Copy link
Copy Markdown
Member

So with one client without clearbufferonmsg module you'll end up receiving the same queries again and again?

@md-5
Copy link
Copy Markdown
Contributor

md-5 commented Apr 4, 2014

@DarthGandalf
Copy link
Copy Markdown
Member

To trigger this line you need to send a command to *status yourself

@omgjlk
Copy link
Copy Markdown
Author

omgjlk commented Apr 4, 2014

No. The ClearAllBuffers command now also clears queries. So if the user has set to always playback then they would issue this command as normal.

@omgjlk
Copy link
Copy Markdown
Author

omgjlk commented Apr 4, 2014

In the case where you're not keeping buffer, and thus you have Auto Clear Chan Buffer set to true, wouldn't it be clearing the buffers as it sends them, thus clearing the query buffer?

@DarthGandalf
Copy link
Copy Markdown
Member

if the user has set to always playback then they would issue this command as normal.

"as normal"?
I have autoclear as off, and never use the ClearAllBuffers command, and I don't have the module loaded. I receive the same channel buffers each time. This is fine for channels, because it gives history of the channel. But it would be annoying for PMs.

You may try @kylef's clientaway module, which makes use of if (!m_pNetwork->IsUserOnline()) (which you remove here)

@omgjlk
Copy link
Copy Markdown
Author

omgjlk commented Apr 11, 2014

clientaway doesn't work for me. I often leave my laptop connected in my office, but will connect from my phone while out and about. If buffers are going to replay, I want /all/ buffers to replay. query buffers shouldn't be a special case, if anything they are more important than channel buffers.

@DarthGandalf
Copy link
Copy Markdown
Member

Then it needs a separate setting (AutoClearQueryBuffer?)

@DarthGandalf
Copy link
Copy Markdown
Member

Superseded by #598

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants