fix(behaviors): Deactivate caps_word after modified numerics#2731
Closed
matthewtodd wants to merge 1 commit intozmkfirmware:mainfrom
Closed
fix(behaviors): Deactivate caps_word after modified numerics#2731matthewtodd wants to merge 1 commit intozmkfirmware:mainfrom
matthewtodd wants to merge 1 commit intozmkfirmware:mainfrom
Conversation
Fixes zmkfirmware#2723. The caps_word behavior now strictly honors `[A-Za-z0-9_]` as the default continuation characters. (Previously `!@#$%^&*()` were mistakenly also honored.) I discovered this by trying to use caps_word for comment markers like `FIXME(mt):` and finding that the opening left parenthesis didn't deactivate caps_word.
Author
|
After asking in Discord, it seems like the path forward is to build something on top of #1742 instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2723.
The caps_word behavior now strictly honors
[A-Za-z0-9_]as the default continuation characters. (Previously!@#$%^&*()were mistakenly also honored.)I discovered this by trying to use caps_word for comment markers like
FIXME(mt):and finding that the opening left parenthesis didn't deactivate caps_word.PR check-list