update ca_is_ca citations, language, expand test coverage#1038
Merged
Conversation
christopher-henderson
approved these changes
May 10, 2026
christopher-henderson
left a comment
Member
There was a problem hiding this comment.
Thank you very much for your ongoing effort on tracking down the historical migrations of CABF!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
checkApplies()and an (incorrectly encoded) explicit false for isCa in the basic constraintscheckApplies()probably looks odd at first glance, but it's more sane than it appears. If there's no basic constraints extension included at all, zlint will interpret the cert as a server certificate and flag it fore_sub_cert_key_usage_cert_sign_bit_setinstead. That's defensible enough, since it is a server cert with certSign set, and it means there's no detection gap here.Documentation References
(Fragment links should go directly to the sections.)