Skip to content

update ca_is_ca citations, language, expand test coverage#1038

Merged
christopher-henderson merged 1 commit into
zmap:masterfrom
mhyder13:ca-is-ca
May 10, 2026
Merged

update ca_is_ca citations, language, expand test coverage#1038
christopher-henderson merged 1 commit into
zmap:masterfrom
mhyder13:ca-is-ca

Conversation

@mhyder13

Copy link
Copy Markdown
Contributor

Overview

  • Updated the citation strings for lint_ca_is_ca
  • Added a comment with the current version of the requirement language and historical references for every previous version of the Baseline Requirements
  • Added some new test cases to cover the checkApplies() and an (incorrectly encoded) explicit false for isCa in the basic constraints
    • That checkApplies() probably looks odd at first glance, but it's more sane than it appears. If there's no basic constraints extension included at all, zlint will interpret the cert as a server certificate and flag it for e_sub_cert_key_usage_cert_sign_bit_set instead. That's defensible enough, since it is a server cert with certSign set, and it means there's no detection gap here.
    • Fundamentally, this lint is a bit of an oddball trying to detect improperly encoded intention from only the resulting certificate which is always going to be somewhat of a guessing game, so I decided not to pitch any changes to its detection logic.
  • Refactored tests into a table-driven test based on previous feedback

Documentation References

(Fragment links should go directly to the sections.)

@christopher-henderson christopher-henderson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your ongoing effort on tracking down the historical migrations of CABF!

@christopher-henderson christopher-henderson merged commit c32a53a into zmap:master May 10, 2026
4 checks passed
@mhyder13 mhyder13 deleted the ca-is-ca branch May 12, 2026 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants