refactor ca country invalid CheckApplies(), add tests, fix typo#1032
Merged
christopher-henderson merged 2 commits intoApr 19, 2026
Conversation
christopher-henderson
requested changes
Apr 5, 2026
christopher-henderson
approved these changes
Apr 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a small refactor to clean up a few things I noticed. I included some more unit testing as a bonus. This change shouldn't cause an externally-visible behavior change to zlint.
e_ca_country_name_invalidfor if there is actually a country included toCheckApplies(), since this check currently explicitly responds NA for that casee_cab_iv_requires_personal_name