Lint e_qcstatem_qctype_web throws an error for legitimate e-signature and e-seal qualified certificates#1004
Merged
Merged
Conversation
… and e-seal qualified certificates
| "qcSmimeNatural.pem": lint.NA, | ||
| "qcSmimeLegal.pem": lint.NA, | ||
| "qcLegal.pem": lint.Error, | ||
| "qcLegal.pem": lint.NA, |
Member
Author
There was a problem hiding this comment.
This one stopped reaching its desired error because it did not have the server auth EKU.
Contributor
|
This solution seems fine to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #1003
The heart of the issue was that this particular lint was using
util.IsServerAuthwhich plays quite fast-and-lose with its definition of what signifies a server auth certificate. Notably, it claims that a certificate with no EKUs at all is a server auth cert. This works well enough for CABF, but it falls on its face in this ETSI lint.Note that this is the only ETSI lint that makes reference to
util.IsServerAuth. So rather than add noutilfacilities it made sense to make the most simplistic change via a simpleutil.HasEkucall.