Add some lints for OCSP Responder certificates#1002
Merged
Conversation
Added //nolint:all to comment block to avoid golangci-lint to complain about duplicate words in comment
Fixed import block
Fine to me. Co-authored-by: Christopher Henderson <chris@chenderson.org>
As per Chris Henderson's suggestion, to "improve readability".
As per Chris Henderson's suggestion.
Added CABFEV_Sec9_2_8_Date
christopher-henderson
approved these changes
Nov 9, 2025
christopher-henderson
left a comment
Member
There was a problem hiding this comment.
Very clean and easy, thank you!
And I see what you meant by "micro lints". It's often tempting to apply DRY and centralize logic, but sometimes the acrobatics just aren't worth it 🤷
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These that I propose here are some of the various lints that can (should) be developed to check that OCSP Responder certificates comply with CABF TLS BRs section 7.1.2.8 (OCSP Responder Certificate Profile).
There are no cases in the Zlint test corpus that trigger these lints, however some can be found on Censys, and in any case every now and then some incidents do happen related to defective OCSP Responder certificates (as recently seen on Bugzilla).