Cmake: Accept custom install dirs in various formats from command line.#885
Merged
Cmake: Accept custom install dirs in various formats from command line.#885
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #885 +/- ##
========================================
Coverage 75.43% 75.43%
========================================
Files 73 73
Lines 8220 8220
Branches 1357 1358 +1
========================================
Hits 6201 6201
Misses 1494 1494
Partials 525 525
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
1f03b95 to
0169971
Compare
Contributor
|
Should this be documented somewhere in addition to the code changes? (which methods are supported?) |
nmoinvaz
reviewed
Mar 17, 2021
Member
|
I'm not a Linux package wizard, but I only noted one thing - otherwise I see nothing obvious. |
nmoinvaz
approved these changes
Mar 17, 2021
Member
Author
|
@gdevenyi I guess it should. Perhaps on the wiki? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add capability for letting command-line parameters of various formats override the installation directories.
This also removes the now unused MAN_INSTALL_DIR.
Fixes #881