Skip to content

Change "None" to "OFF" for sanitizer option#2141

Merged
Dead2 merged 2 commits intozlib-ng:developfrom
pps83:develop-san-off
Feb 6, 2026
Merged

Change "None" to "OFF" for sanitizer option#2141
Dead2 merged 2 commits intozlib-ng:developfrom
pps83:develop-san-off

Conversation

@pps83
Copy link
Copy Markdown
Contributor

@pps83 pps83 commented Feb 4, 2026 •
edited
Loading

Originally posted by @benoit-pierre in #2119 (comment)

@pps83 pps83 mentioned this pull request Feb 4, 2026
Merged
benoit-pierre
benoit-pierre reviewed Feb 4, 2026
View reviewed changes
@pps83 @benoit-pierre
Update CMakeLists.txt
9afcbb1 
Co-authored-by: Benoit Pierre <benoit.pierre@gmail.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 4, 2026 •
edited
Loading

Walkthrough

Changed the CMake WITH_SANITIZER cache option so the first/visible token for disabling sanitizers is OFF (and the default is OFF) instead of the previous None; all other allowed sanitizer values remain unchanged.

Changes

Cohort / File(s) Summary
Build Configuration
CMakeLists.txt		 Updated WITH_SANITIZER multi-choice cache option: replaced the first choice string from "None"/AUTO to OFF and set the default to OFF; other sanitizer options (Memory, Address, Undefined, Thread) unchanged.

Possibly related PRs

Suggested labels

Build Env

Suggested reviewers

  • nmoinvaz
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: updating the sanitizer option default value from 'None' to 'OFF' in CMakeLists.txt.
Description check ✅ Passed The description references the original issue discussion where this change was proposed, providing context for the modification even though it lacks detail.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Important

Action Needed: IP Allowlist Update

If your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:

  • ✨ 136.113.208.247/32 (new)
  • 34.170.211.100/32
  • 35.222.179.152/32

Reviews will stop working after February 8, 2026 if the new IP is not added to your allowlist.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coveralls
Copy link
Copy Markdown

coveralls commented Feb 4, 2026

Coverage Status

coverage: 94.682% (-0.06%) from 94.743%
when pulling 9afcbb1 on pps83:develop-san-off
into fd05368 on zlib-ng:develop.

@Dead2 Dead2 merged commit 99e356f into zlib-ng:develop Feb 6, 2026
148 checks passed
@pps83 pps83 deleted the develop-san-off branch February 6, 2026 10:39
@coderabbitai coderabbitai bot mentioned this pull request Feb 15, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nmoinvaz nmoinvaz nmoinvaz approved these changes

+1 more reviewer

@benoit-pierre benoit-pierre benoit-pierre left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Build Env

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pps83 @coveralls @nmoinvaz @benoit-pierre @Dead2