Remove leftover memory alloc test in deflateinit#2092
Conversation
no longer necessary as we only allocate a single buffer and has already been checked for failure before this.
WalkthroughA memory validation block in deflateInit2 that checked for null pointers in allocated buffers (s->window, s->prev, s->head, s->pending_buf) and performed error cleanup was removed. The function now proceeds without this explicit early validation. Changes
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2092 +/- ##
===========================================
+ Coverage 84.25% 85.36% +1.11%
===========================================
Files 155 155
Lines 12862 12857 -5
Branches 3114 3113 -1
===========================================
+ Hits 10837 10976 +139
+ Misses 1042 912 -130
+ Partials 983 969 -14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
deflateinit was still checking for failed secondary allocations, this is
no longer necessary as we only allocate a single buffer and has already been checked for failure before this.