[Configure] Fix SFLAGS and improve sed portability#2016
Merged
Dead2 merged 1 commit intozlib-ng:developfrom Nov 20, 2025
Merged
[Configure] Fix SFLAGS and improve sed portability#2016Dead2 merged 1 commit intozlib-ng:developfrom
Dead2 merged 1 commit intozlib-ng:developfrom
Conversation
Contributor
WalkthroughCompile-time build rules were adjusted for two x86 shared-object targets to use SFLAGS instead of CFLAGS, and two sed regex patterns in the generated configure script were corrected by removing an unnecessary backslash in the include-matching expression. Changes
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (135)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2016 +/- ##
===========================================
- Coverage 82.77% 79.64% -3.13%
===========================================
Files 163 163
Lines 12862 12862
Branches 3171 3168 -3
===========================================
- Hits 10646 10244 -402
- Misses 1186 1556 +370
- Partials 1030 1062 +32 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* "\i" is not valid escape code in BSD sed * Some x86 shared sources were missing -fPIC due to using wrong variable in build rule Fixes zlib-ng#2015.
318a27a to
02ab052
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR fixes two build issues when using the configure script on BSD systems:
- Removes invalid
\iescape sequence in sed commands that caused failures on BSD sed - Corrects compilation flags for shared object files in x86 architecture to include
-fPIC
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| configure | Fixed sed regex pattern by changing \include to include - the backslash-i escape sequence is not valid in BSD sed |
| arch/x86/Makefile.in | Fixed chorba_sse2.lo and chorba_sse41.lo build rules to use SFLAGS instead of CFLAGS, ensuring -fPIC is included for shared library compilation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
@brad0 Could you please test this to verify the fix works as it should? |
Contributor
|
@Dead2 Tested. This resolves the error and builds Ok. |
Dead2
approved these changes
Nov 18, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2015.