Skip to content

Update Google Benchmark to v1.9.4#2013

Merged
Dead2 merged 1 commit intozlib-ng:developfrom
mtl1979:benchmark-1.9.4
Nov 18, 2025
Merged

Update Google Benchmark to v1.9.4#2013
Dead2 merged 1 commit intozlib-ng:developfrom
mtl1979:benchmark-1.9.4

Conversation

@mtl1979
Copy link
Copy Markdown
Collaborator

@mtl1979 mtl1979 commented Nov 17, 2025 •
edited
Loading

Contains fixes for building on OpenBSD.

Fixes #2011.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Nov 17, 2025 •
edited
Loading

Walkthrough

Bumped the default Google Benchmark tag in the CMake build configuration from v1.7.1 to v1.9.4, affecting the FetchContent_Declare invocation in test/benchmarks/CMakeLists.txt when GBENCHMARK_TAG is not pre-set.

Changes

Cohort / File(s) Summary
Google Benchmark version upgrade
test/benchmarks/CMakeLists.txt		 Changed default GBENCHMARK_TAG from v1.7.1 to v1.9.4 in the FetchContent_Declare call.

Possibly related issues

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: updating Google Benchmark from v1.7.1 to v1.9.4, which matches the primary modification in the changeset.
Description check ✅ Passed The description is related to the changeset. It mentions fixes for building on OpenBSD and references issue #2011, which is the motivation for updating Google Benchmark.
Linked Issues check ✅ Passed The PR successfully addresses issue #2011 by updating Google Benchmark from v1.7.1 to v1.9.4, which exceeds the minimum v1.9.2 requirement and includes the OpenBSD build fix referenced in the issue.
Out of Scope Changes check ✅ Passed All changes are in scope. The cmake_minimum_required version bump from 3.12 to 3.13 is a necessary adjustment to support Google Benchmark v1.9.4, making it directly related to the stated objective.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8a38a6e and 3a9f2a1.

📒 Files selected for processing (1)
  • test/benchmarks/CMakeLists.txt (2 hunks)
🔇 Additional comments (2)
test/benchmarks/CMakeLists.txt (2)

1-1: Verify CMake minimum version requirement for Google Benchmark v1.9.4.

The cmake_minimum_required was bumped from 3.12 to 3.13. Please confirm whether this is a hard requirement for Google Benchmark v1.9.4 compatibility or if 3.12 remains sufficient. If 3.12 is still compatible, reverting this change could improve backward compatibility.

26-26: Verification complete: Google Benchmark v1.9.4 is a stable release containing the OpenBSD fix.

v1.9.4 (released May 19, 2025) includes the OpenBSD build fixes introduced in v1.8.0. No build system breaking changes identified. Note: v1.9.0 introduced a breaking change in benchmark result reporting (removed spurious thread-scaling factor, now reports wall-time instead of scaled time), so benchmark results will differ from v1.8.x; ensure any result comparisons or CI thresholds account for this semantic change.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 17, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.73%. Comparing base (6d8c1ac) to head (3a9f2a1).
⚠️ Report is 3 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2013      +/-   ##
===========================================
+ Coverage    82.37%   82.73%   +0.35%     
===========================================
  Files          163      163              
  Lines        12862    12863       +1     
  Branches      3171     3171              
===========================================
+ Hits         10595    10642      +47     
+ Misses        1201     1147      -54     
- Partials      1066     1074       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Dead2 Dead2 merged commit 4c3ef45 into zlib-ng:develop Nov 18, 2025
155 of 156 checks passed
@Dead2 Dead2 mentioned this pull request Nov 25, 2025
Merged
@coderabbitai coderabbitai bot mentioned this pull request Apr 8, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nmoinvaz nmoinvaz nmoinvaz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Updating Google Benchmark

3 participants

@mtl1979 @nmoinvaz @Dead2