Skip to content

Use 'block-list' and 'allow-list' terms#1976

Merged
Dead2 merged 2 commits intozlib-ng:developfrom
jeffhandley:jeffhandley/allow-block-list-term
Oct 7, 2025
Merged

Use 'block-list' and 'allow-list' terms#1976
Dead2 merged 2 commits intozlib-ng:developfrom
jeffhandley:jeffhandley/allow-block-list-term

Conversation

@jeffhandley
Copy link
Copy Markdown
Contributor

@jeffhandley jeffhandley commented Oct 2, 2025

This was found when running a scanner for unfavorable terms. I kept "gray-listed" in place though since gray areas are OK.

Summary by CodeRabbit

  • Refactor
    • Replaced non-inclusive terminology with inclusive alternatives across detection logic; behavior and outputs unchanged.
  • Documentation
    • Updated explanatory text and examples to use the new terminology; no user-facing changes.
  • Style
    • Minor wording and readability tweaks in comments and descriptions, preserving identical functionality.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Oct 2, 2025

Walkthrough

Replaces “black list/white list” terminology with “block list/allow list” in code and documentation; renames internal variable black_mask to block_mask in trees.c. Changes are terminology and naming only; no control flow, algorithm, or functional behavior alterations.

Changes

Cohort / File(s) Change summary
Code: terminology & variable rename
trees.c
Renamed black_maskblock_mask; updated loop and condition references and comments from “black-listed”/“white-listed” to “block-listed”/“allow-listed”. No logic change.
Docs: terminology updates
doc/txtvsbin.txt
Replaced wording: “white list” → “allow list”, “black list” → “block list”, and updated related examples and explanations. No functional changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title succinctly conveys the primary focus on replacing deprecated terminology with "block-list" and "allow-list" and directly reflects the changes made in both code and documentation. It is concise, specific, and free of irrelevant details or generic phrasing. Therefore, it effectively communicates the main intent of the pull request to reviewers scanning the history.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 11957f9 and d271782.

📒 Files selected for processing (1)
  • doc/txtvsbin.txt (2 hunks)
✅ Files skipped from review due to trivial changes (1)
  • doc/txtvsbin.txt

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nmoinvaz
Copy link
Copy Markdown
Member

nmoinvaz commented Oct 3, 2025

I remember an old zlib issue about this. We should see what Mark did.

@jeffhandley
Copy link
Copy Markdown
Contributor Author

@nmoinvaz I found the corresponding change in zlib. Here's the commit: madler/zlib@8678871#diff-98dbe62a944e219f1245cf05c7eca4fec56ffbcc992dd3083817f4a720312da2

That led me to find the txtvsbin.txt file having the terms too, and those were updated in zlib so I updated them here too. "gray-list" was left in place there too.

Here's where Mark concluded to make the change: madler/zlib#511 (comment)

@mtl1979
Copy link
Copy Markdown
Collaborator

mtl1979 commented Oct 3, 2025

I think it's good that we get rid of the wording that do not fit in today's world. As long as the wording doesn't appear in a quote of what someone has said, we don't need to care if Adler already did same change.

In some parts we should follow what Adler has changed to avoid deviating too much and making importing new patches too much hassle, but there is already other minor differences that require manual resolving of merge conflicts when doing three-way merge.

@Dead2 Dead2 merged commit 3aaa079 into zlib-ng:develop Oct 7, 2025
2 checks passed
@Dead2 Dead2 mentioned this pull request Nov 5, 2025
@jeffhandley jeffhandley deleted the jeffhandley/allow-block-list-term branch December 30, 2025 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants