Use 'block-list' and 'allow-list' terms#1976
Conversation
WalkthroughReplaces “black list/white list” terminology with “block list/allow list” in code and documentation; renames internal variable Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
I remember an old zlib issue about this. We should see what Mark did. |
|
@nmoinvaz I found the corresponding change in zlib. Here's the commit: madler/zlib@8678871#diff-98dbe62a944e219f1245cf05c7eca4fec56ffbcc992dd3083817f4a720312da2 That led me to find the txtvsbin.txt file having the terms too, and those were updated in zlib so I updated them here too. "gray-list" was left in place there too. Here's where Mark concluded to make the change: madler/zlib#511 (comment) |
|
I think it's good that we get rid of the wording that do not fit in today's world. As long as the wording doesn't appear in a quote of what someone has said, we don't need to care if Adler already did same change. In some parts we should follow what Adler has changed to avoid deviating too much and making importing new patches too much hassle, but there is already other minor differences that require manual resolving of merge conflicts when doing three-way merge. |
This was found when running a scanner for unfavorable terms. I kept "gray-listed" in place though since gray areas are OK.
Summary by CodeRabbit