Merged
Conversation
Contributor
WalkthroughThis PR removes the chunksize function and related indirections across architectures, eliminates the functable entry and inflate_state field for chunksize, and replaces usages with a static inline CHUNKSIZE() returning sizeof(chunk_t). Call sites in inflate/init paths are adjusted accordingly. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Caller
participant Inflate as inflate/inflateBack
participant Inffast as inffast_tpl
participant Chunkset as CHUNKSIZE()
Caller->>Inflate: initialize/execute
note over Inflate: state->chunksize removed
Inflate->>Inffast: decode and copy
Inffast->>Chunkset: CHUNKSIZE()
Chunkset-->>Inffast: sizeof(chunk_t)
alt dist >= CHUNKSIZE()
Inffast->>Inffast: use CHUNK-copy path
else dist < CHUNKSIZE()
Inffast->>Inffast: use short copy path
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (13)
💤 Files with no reviewable changes (11)
🧰 Additional context used🧠 Learnings (6)📚 Learning: 2024-10-04T03:17:24.773ZApplied to files:
📚 Learning: 2024-10-17T03:29:32.723ZApplied to files:
📚 Learning: 2024-10-07T22:00:02.180ZApplied to files:
📚 Learning: 2024-10-29T02:22:52.846ZApplied to files:
📚 Learning: 2024-10-07T21:23:13.401ZApplied to files:
📚 Learning: 2025-06-10T07:38:03.297ZApplied to files:
🧬 Code graph analysis (2)chunkset_tpl.h (1)
inffast_tpl.h (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (87)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1974 +/- ##
===========================================
+ Coverage 80.86% 81.53% +0.67%
===========================================
Files 161 161
Lines 13741 13726 -15
Branches 3117 3113 -4
===========================================
+ Hits 11111 11192 +81
+ Misses 1603 1475 -128
- Partials 1027 1059 +32 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Refactor
Performance