test/fuzz/fuzzer_compress.c (4)

17-18: Check return codes from compress2/uncompress.

Capture and assert return values so failures are attributed to the fuzzer, not hidden by later asserts.

-    PREFIX(compress2)(compr, &comprLen, data, dataLen, level);
-    PREFIX(uncompress)(uncompr, &uncomprLen, compr, comprLen);
+    int cr = PREFIX(compress2)(compr, &comprLen, data, dataLen, level);
+    assert(cr == Z_OK);
+    int ur = PREFIX(uncompress)(uncompr, &uncomprLen, compr, comprLen);
+    assert(ur == Z_OK);

---

40-51: Type consistency: avoid implicit size_t → z_uintmax_t conversion.

Passing copyLen (size_t) to uncompress (expects z_uintmax_t) is safe but can warn under -Wconversion. Make the cast explicit.

-    PREFIX(uncompress)(compr, &comprLen, copy, copyLen);
+    PREFIX(uncompress)(compr, &comprLen, copy, (z_uintmax_t)copyLen);

---

1-9: Add missing standard headers for memcpy/memcmp/malloc/free.

Some builds rely on transitive includes; be explicit to avoid implicit declarations.

 #include <stdio.h>
 #include <assert.h>
+#include <string.h>  /* memcpy, memcmp */
+#include <stdlib.h>  /* malloc, free   */

---

59-61: Minor: const instead of static for kMaxSize.

It’s not mutated; const communicates intent and allows better optimization.

-    static size_t kMaxSize = 1024 * 1024;
+    const size_t kMaxSize = 1024u * 1024u;

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Learnt from: samrussell
PR: zlib-ng/zlib-ng#1914
File: arch/generic/crc32_chorba_c.c:30-32
Timestamp: 2025-05-13T06:56:12.407Z
Learning: In zlib-ng, pointer casts between z_word_t* and uint64_t* are safe because: 1) On 64-bit platforms, z_word_t is defined as uint64_t, making the cast a no-op; 2) On 32-bit platforms where z_word_t is uint32_t, the code paths using uint64_t* are skipped in favor of 32-bit specific implementations.