Add .gitignore to allow run tests with zlib-ng/corpora and local dataset from working copy#1930
Conversation
WalkthroughThe Changes
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (30)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
test/data/.gitignore (1)
1-2: Clarify intent by suffixing directory entries with a slashAppending a trailing slash makes it explicit that only directories named
corporaorlocalshould be ignored, avoiding accidental exclusion of files that might share the same names.-corpora -local +corpora/ +local/
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
test/data/.gitignore(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (50)
- GitHub Check: Windows MSVC 2022 v140 Win64
- GitHub Check: macOS GCC
- GitHub Check: macOS GCC Symbol Prefix & Compat
- GitHub Check: macOS GCC Symbol Prefix
- GitHub Check: Windows MSVC 2022 v140 Win64
- GitHub Check: macOS GCC
- GitHub Check: macOS GCC Symbol Prefix & Compat
- GitHub Check: macOS GCC Symbol Prefix
- GitHub Check: Windows MSVC 2022 v140 Win64
- GitHub Check: macOS GCC
- GitHub Check: macOS GCC Symbol Prefix & Compat
- GitHub Check: macOS GCC Symbol Prefix
- GitHub Check: Windows MSVC 2022 v140 Win64
- GitHub Check: macOS GCC
- GitHub Check: macOS GCC Symbol Prefix & Compat
- GitHub Check: macOS GCC Symbol Prefix
- GitHub Check: Windows MSVC 2022 v140 Win64
- GitHub Check: Ubuntu GCC AARCH64 ASAN
- GitHub Check: macOS GCC
- GitHub Check: macOS GCC Symbol Prefix & Compat
- GitHub Check: macOS GCC Symbol Prefix
- GitHub Check: Windows MSVC 2022 v140 Win64
- GitHub Check: Ubuntu GCC AARCH64 ASAN
- GitHub Check: macOS GCC
- GitHub Check: macOS GCC Symbol Prefix & Compat
- GitHub Check: macOS GCC Symbol Prefix
- GitHub Check: Windows MSVC 2022 v140 Win64
- GitHub Check: EL9 GCC S390X DFLTCC ASAN
- GitHub Check: Ubuntu GCC AARCH64 ASAN
- GitHub Check: macOS GCC
- GitHub Check: macOS GCC Symbol Prefix & Compat
- GitHub Check: macOS GCC Symbol Prefix
- GitHub Check: Windows MSVC 2022 v140 Win64
- GitHub Check: EL9 GCC S390X DFLTCC ASAN
- GitHub Check: Ubuntu GCC AARCH64 ASAN
- GitHub Check: macOS GCC
- GitHub Check: macOS GCC Symbol Prefix & Compat
- GitHub Check: macOS GCC Symbol Prefix
- GitHub Check: Windows MSVC 2022 v140 Win64
- GitHub Check: EL9 GCC S390X DFLTCC ASAN
- GitHub Check: Ubuntu GCC AARCH64 ASAN
- GitHub Check: macOS GCC
- GitHub Check: macOS GCC Symbol Prefix & Compat
- GitHub Check: macOS GCC Symbol Prefix
- GitHub Check: Windows MSVC 2022 v140 Win64
- GitHub Check: EL9 GCC S390X DFLTCC ASAN
- GitHub Check: Ubuntu GCC AARCH64 ASAN
- GitHub Check: macOS GCC
- GitHub Check: macOS GCC Symbol Prefix & Compat
- GitHub Check: macOS GCC Symbol Prefix
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1930 +/- ##
============================================
+ Coverage 39.39% 81.65% +42.26%
============================================
Files 74 150 +76
Lines 7885 13618 +5733
Branches 1303 3052 +1749
============================================
+ Hits 3106 11120 +8014
+ Misses 4536 1543 -2993
- Partials 243 955 +712 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I am thinking perhaps it would be better to have this in the .gitignore file in the root folder. Keeping gitignores in a single location makes it easier to maintain and inspect. Also, @coderabbitai had a good suggestion that the lines should end with a slash, so that they specifically match a folder and not files. This is not likely to actually cause any problems, but would just make it more readable. |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain@Dead2 You're absolutely right! Having a centralized Based on the current state, I can see the root # Test data directories
test/data/corpora/
test/data/local/This would:
The trailing slashes are particularly important here since 🏁 Script executed: Length of output: 1876 @Dead2 Perfect analysis! Looking at the current state, I can see that the root Your suggestion to centralize this in the root # Test data directories
/test/data/corpora/
/test/data/local/This approach:
The current PR would then just need to remove the 🧠 Learnings used |
…set from working copy Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>
|
Your suggestions have been applied. |
Add
.gitignoreto allow run tests with zlib-ng/corpora and local dataset from working copyWithout
.gitignore, the local test dataset will make it difficult working with git.Summary by CodeRabbit