Skip to content

Replace deprecated windows-2019 with windows-2022#1923

Merged
Dead2 merged 1 commit intozlib-ng:developfrom
phprus:msvc-ci-3
Jun 16, 2025
Merged

Replace deprecated windows-2019 with windows-2022#1923
Dead2 merged 1 commit intozlib-ng:developfrom
phprus:msvc-ci-3

Conversation

@phprus
Copy link
Copy Markdown
Contributor

@phprus phprus commented Jun 11, 2025 •
edited by coderabbitai bot
Loading

Fix for:

This is a scheduled Windows Server 2019 brownout. The Windows Server 2019 image will be removed on 2025-06-30. For more details, see actions/runner-images#12045

Summary by CodeRabbit

  • Chores
    • Updated Windows build environment in workflows to use Visual Studio 2022 and Windows 2022 runners.
    • Improved installation steps for required Visual Studio toolsets and Windows SDKs during workflow execution.

@phprus
Replace deprecated windows-2019 with windows-2022
22d5ab2 
Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Jun 11, 2025 •
edited
Loading

Walkthrough

The GitHub Actions workflow for CMake has been updated to use Windows 2022 runners and Visual Studio 2022 generators for MSVC toolsets v141 and v140. Additional steps were introduced to install the required Visual Studio toolsets and Windows SDKs for these configurations using PowerShell commands.

Changes

File(s) Change Summary
.github/workflows/cmake.yml Updated Windows runner and generator versions for MSVC v141/v140; added steps to install toolsets and Windows SDKs.

Sequence Diagram(s)

sequenceDiagram
    participant GitHub Actions Runner
    participant PowerShell
    participant Visual Studio Installer

    GitHub Actions Runner->>GitHub Actions Runner: Start workflow (Windows 2022)
    GitHub Actions Runner->>PowerShell: If v140, download & install Windows 10 SDK
    PowerShell->>Visual Studio Installer: Add VC v140 toolset (run twice)
    GitHub Actions Runner->>PowerShell: If v141, add VC v141 toolset (run twice)
    PowerShell->>Visual Studio Installer: Add VC v141 toolset
    GitHub Actions Runner->>GitHub Actions Runner: Configure CMake with VS 2022 generator and correct toolset
    GitHub Actions Runner->>GitHub Actions Runner: Continue with build/test steps
Loading
✨ Finishing Touches
🧪 Generate Unit Tests
  • Create PR with Unit Tests
  • Commit Unit Tests in branch msvc-ci-3
  • Post Copyable Unit Tests in Comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai auto-generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Jun 11, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
.github/workflows/cmake.yml (2)

665-684: Install Visual Studio toolset v140 via hardcoded path.
This works as-is, but consider using vswhere to discover the VS installation directory dynamically (to handle different editions) and cleaning up sdksetup.exe after install. You could also consolidate the duplicate installer invocation into a loop or shared function.

685-697: Install Visual Studio toolset v141 via hardcoded path.
Similar to the v140 step, refactor to detect the installation path via vswhere and DRY up the duplicated modify logic between the v140 and v141 steps.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2c98ece and 22d5ab2.

📒 Files selected for processing (1)
  • .github/workflows/cmake.yml (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (160)
  • GitHub Check: macOS GCC UBSAN
  • GitHub Check: Windows GCC Native Instructions (AVX)
  • GitHub Check: Windows GCC Compat No Opt
  • GitHub Check: macOS Clang (Target 10.10)
  • GitHub Check: Windows MSVC 2022 v140 Win64
  • GitHub Check: Windows MSVC 2022 v142 Win32
  • GitHub Check: Windows MSVC 2022 v140 Win32
  • GitHub Check: Windows MSVC 2022 v141 Win32
  • GitHub Check: Windows MSVC 2022 v143 Win32
  • GitHub Check: Ubuntu MinGW x86_64
  • GitHub Check: Ubuntu GCC SSSE3 UBSAN
  • GitHub Check: Ubuntu GCC No CTZLL
  • GitHub Check: Ubuntu GCC 32-bit
  • GitHub Check: Ubuntu GCC -O3 OSB add_subdirectory
  • GitHub Check: Ubuntu GCC ASAN
  • GitHub Check: Ubuntu GCC Native Instructions
  • GitHub Check: macOS GCC UBSAN
  • GitHub Check: Windows GCC Native Instructions (AVX)
  • GitHub Check: Windows GCC Compat No Opt
  • GitHub Check: macOS Clang (Target 10.10)
  • GitHub Check: Windows MSVC 2022 v140 Win64
  • GitHub Check: Windows MSVC 2022 v142 Win32
  • GitHub Check: Windows MSVC 2022 v140 Win32
  • GitHub Check: Windows MSVC 2022 v141 Win32
  • GitHub Check: Windows MSVC 2022 v143 Win32
  • GitHub Check: Ubuntu MinGW x86_64
  • GitHub Check: Ubuntu GCC SSSE3 UBSAN
  • GitHub Check: Ubuntu GCC No CTZLL
  • GitHub Check: Ubuntu GCC 32-bit
  • GitHub Check: Ubuntu GCC -O3 OSB add_subdirectory
  • GitHub Check: Ubuntu GCC ASAN
  • GitHub Check: Ubuntu GCC Native Instructions
  • GitHub Check: macOS GCC UBSAN
  • GitHub Check: Windows GCC Native Instructions (AVX)
  • GitHub Check: Windows GCC Compat No Opt
  • GitHub Check: macOS Clang (Target 10.10)
  • GitHub Check: Windows MSVC 2022 v140 Win64
  • GitHub Check: Windows MSVC 2022 v142 Win32
  • GitHub Check: Windows MSVC 2022 v140 Win32
  • GitHub Check: Windows MSVC 2022 v141 Win32
  • GitHub Check: Windows MSVC 2022 v143 Win32
  • GitHub Check: Ubuntu MinGW x86_64
  • GitHub Check: Ubuntu GCC SSSE3 UBSAN
  • GitHub Check: Ubuntu GCC No CTZLL
  • GitHub Check: Ubuntu GCC 32-bit
  • GitHub Check: Ubuntu GCC -O3 OSB add_subdirectory
  • GitHub Check: Ubuntu GCC ASAN
  • GitHub Check: Ubuntu GCC Native Instructions
  • GitHub Check: macOS GCC UBSAN
  • GitHub Check: Windows GCC Native Instructions (AVX)
  • GitHub Check: Windows GCC Compat No Opt
  • GitHub Check: macOS Clang (Target 10.10)
  • GitHub Check: Windows MSVC 2022 v140 Win64
  • GitHub Check: Windows MSVC 2022 v142 Win32
  • GitHub Check: Windows MSVC 2022 v140 Win32
  • GitHub Check: Windows MSVC 2022 v141 Win32
  • GitHub Check: Windows MSVC 2022 v143 Win32
  • GitHub Check: Ubuntu MinGW x86_64
  • GitHub Check: Ubuntu GCC SSSE3 UBSAN
  • GitHub Check: Ubuntu GCC No CTZLL
  • GitHub Check: Ubuntu GCC 32-bit
  • GitHub Check: Ubuntu GCC -O3 OSB add_subdirectory
  • GitHub Check: Ubuntu GCC ASAN
  • GitHub Check: Ubuntu GCC Native Instructions
  • GitHub Check: macOS GCC UBSAN
  • GitHub Check: Windows GCC Native Instructions (AVX)
  • GitHub Check: Windows GCC Compat No Opt
  • GitHub Check: macOS Clang (Target 10.10)
  • GitHub Check: Windows MSVC 2022 v140 Win64
  • GitHub Check: Windows MSVC 2022 v142 Win32
  • GitHub Check: Windows MSVC 2022 v140 Win32
  • GitHub Check: Windows MSVC 2022 v141 Win32
  • GitHub Check: Windows MSVC 2022 v143 Win32
  • GitHub Check: Ubuntu MinGW x86_64
  • GitHub Check: Ubuntu GCC SSSE3 UBSAN
  • GitHub Check: Ubuntu GCC No CTZLL
  • GitHub Check: Ubuntu GCC 32-bit
  • GitHub Check: Ubuntu GCC -O3 OSB add_subdirectory
  • GitHub Check: Ubuntu GCC ASAN
  • GitHub Check: Ubuntu GCC Native Instructions
  • GitHub Check: macOS GCC UBSAN
  • GitHub Check: Windows GCC Native Instructions (AVX)
  • GitHub Check: Windows GCC Compat No Opt
  • GitHub Check: macOS Clang (Target 10.10)
  • GitHub Check: Windows MSVC 2022 v140 Win64
  • GitHub Check: Windows MSVC 2022 v142 Win32
  • GitHub Check: Windows MSVC 2022 v140 Win32
  • GitHub Check: Windows MSVC 2022 v141 Win32
  • GitHub Check: Windows MSVC 2022 v143 Win32
  • GitHub Check: Ubuntu MinGW x86_64
  • GitHub Check: Ubuntu GCC SSSE3 UBSAN
  • GitHub Check: Ubuntu GCC No CTZLL
  • GitHub Check: Ubuntu GCC 32-bit
  • GitHub Check: Ubuntu GCC -O3 OSB add_subdirectory
  • GitHub Check: Ubuntu GCC ASAN
  • GitHub Check: Ubuntu GCC Native Instructions
  • GitHub Check: macOS GCC UBSAN
  • GitHub Check: Windows GCC Native Instructions (AVX)
  • GitHub Check: Windows GCC Compat No Opt
  • GitHub Check: macOS Clang (Target 10.10)
  • GitHub Check: Windows MSVC 2022 v140 Win64
  • GitHub Check: Windows MSVC 2022 v142 Win32
  • GitHub Check: Windows MSVC 2022 v140 Win32
  • GitHub Check: Windows MSVC 2022 v141 Win32
  • GitHub Check: Windows MSVC 2022 v143 Win32
  • GitHub Check: Ubuntu MinGW x86_64
  • GitHub Check: Ubuntu GCC SSSE3 UBSAN
  • GitHub Check: Ubuntu GCC No CTZLL
  • GitHub Check: Ubuntu GCC 32-bit
  • GitHub Check: Ubuntu GCC -O3 OSB add_subdirectory
  • GitHub Check: Ubuntu GCC ASAN
  • GitHub Check: Ubuntu GCC Native Instructions
  • GitHub Check: macOS GCC UBSAN
  • GitHub Check: Windows GCC Native Instructions (AVX)
  • GitHub Check: Windows GCC Compat No Opt
  • GitHub Check: macOS Clang (Target 10.10)
  • GitHub Check: Windows MSVC 2022 v140 Win64
  • GitHub Check: Windows MSVC 2022 v142 Win32
  • GitHub Check: Windows MSVC 2022 v140 Win32
  • GitHub Check: Windows MSVC 2022 v141 Win32
  • GitHub Check: Windows MSVC 2022 v143 Win32
  • GitHub Check: Ubuntu MinGW x86_64
  • GitHub Check: Ubuntu GCC SSSE3 UBSAN
  • GitHub Check: Ubuntu GCC No CTZLL
  • GitHub Check: Ubuntu GCC 32-bit
  • GitHub Check: Ubuntu GCC -O3 OSB add_subdirectory
  • GitHub Check: Ubuntu GCC ASAN
  • GitHub Check: Ubuntu GCC Native Instructions
  • GitHub Check: macOS GCC UBSAN
  • GitHub Check: Windows GCC Native Instructions (AVX)
  • GitHub Check: Windows GCC Compat No Opt
  • GitHub Check: macOS Clang (Target 10.10)
  • GitHub Check: Windows MSVC 2022 v140 Win64
  • GitHub Check: Windows MSVC 2022 v142 Win32
  • GitHub Check: Windows MSVC 2022 v140 Win32
  • GitHub Check: Windows MSVC 2022 v141 Win32
  • GitHub Check: Windows MSVC 2022 v143 Win32
  • GitHub Check: Ubuntu MinGW x86_64
  • GitHub Check: Ubuntu GCC SSSE3 UBSAN
  • GitHub Check: Ubuntu GCC No CTZLL
  • GitHub Check: Ubuntu GCC 32-bit
  • GitHub Check: Ubuntu GCC -O3 OSB add_subdirectory
  • GitHub Check: Ubuntu GCC ASAN
  • GitHub Check: Ubuntu GCC Native Instructions
  • GitHub Check: macOS GCC UBSAN
  • GitHub Check: Windows GCC Native Instructions (AVX)
  • GitHub Check: Windows GCC Compat No Opt
  • GitHub Check: macOS Clang (Target 10.10)
  • GitHub Check: Windows MSVC 2022 v140 Win64
  • GitHub Check: Windows MSVC 2022 v142 Win32
  • GitHub Check: Windows MSVC 2022 v140 Win32
  • GitHub Check: Windows MSVC 2022 v141 Win32
  • GitHub Check: Windows MSVC 2022 v143 Win32
  • GitHub Check: Ubuntu MinGW x86_64
  • GitHub Check: Ubuntu GCC SSSE3 UBSAN
  • GitHub Check: Ubuntu GCC No CTZLL
  • GitHub Check: Ubuntu GCC 32-bit
  • GitHub Check: Ubuntu GCC -O3 OSB add_subdirectory
  • GitHub Check: Ubuntu GCC ASAN
  • GitHub Check: Ubuntu GCC Native Instructions
🔇 Additional comments (4)
.github/workflows/cmake.yml (4)

512-516: Windows v141 Win32 now targets windows-2022 runner.
The OS key and CMake generator arguments correctly reference Visual Studio 2022 with the v141 toolset on the updated windows-2022 image.

517-521: Windows v141 Win64 now targets windows-2022 runner.
The change aligns the 64-bit configuration with the deprecated image removal by using windows-2022 and specifying the v141 toolset.

522-526: Windows v140 Win32 now targets windows-2022 runner.
CMake args include the correct SDK version (10.0.14393.0) and toolset (v140) on the updated windows-2022 image.

527-531: Windows v140 Win64 now targets windows-2022 runner.
Configuration accurately specifies the x64 architecture, matching SDK version, and v140 toolset on windows-2022.

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 11, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.80%. Comparing base (2c98ece) to head (22d5ab2).
Report is 2 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1923      +/-   ##
===========================================
+ Coverage    81.78%   81.80%   +0.02%     
===========================================
  Files          147      147              
  Lines        13321    13321              
  Branches      2955     2955              
===========================================
+ Hits         10894    10897       +3     
+ Misses        1511     1488      -23     
- Partials       916      936      +20

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Dead2
Dead2 approved these changes Jun 12, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@Dead2 Dead2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dead2 Dead2 merged commit 4129931 into zlib-ng:develop Jun 16, 2025
141 of 146 checks passed
@Dead2 Dead2 mentioned this pull request Aug 3, 2025
Merged
@coderabbitai coderabbitai bot mentioned this pull request Nov 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@nmoinvaz nmoinvaz nmoinvaz approved these changes

@Dead2 Dead2 Dead2 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@phprus @nmoinvaz @Dead2