Skip to content

Add bindir into zlib.pc.in for compatibility with Cygwin and Msys2#1920

Merged
Dead2 merged 1 commit intozlib-ng:developfrom
phprus:pkgconfig-msys2-1
Jun 16, 2025
Merged

Add bindir into zlib.pc.in for compatibility with Cygwin and Msys2#1920
Dead2 merged 1 commit intozlib-ng:developfrom
phprus:pkgconfig-msys2-1

Conversation

@phprus
Copy link
Copy Markdown
Contributor

@phprus phprus commented Jun 6, 2025 •
edited
Loading

Fix for issue #1918

In Msys2 and Cygwin, the sharedlibdir variable is set to ${bindir}, which bindir was undefined.

zlib-ng/configure

Lines 390 to 395 in 2c98ece

CYGWIN* | Cygwin* | cygwin*)
visibility=0
ARFLAGS="rcs"
SFLAGS="${CFLAGS}"
shared_ext='.dll'
sharedlibdir='${bindir}'

zlib-ng/configure

Lines 416 to 421 in 2c98ece

MSYS* | msys*)
visibility=0
ARFLAGS="rcs"
SFLAGS="${CFLAGS}"
shared_ext='.dll'
sharedlibdir='${bindir}'

Summary by CodeRabbit

  • Chores
    • Added the bindir directory path as a variable in the pkg-config template for improved environment configuration.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Jun 6, 2025 •
edited
Loading

Walkthrough

The pkg-config files zlib.pc.in and zlib.pc.cmakein were updated to include a new bindir variable representing the binary installation directory. Correspondingly, CMakeLists.txt was modified to handle the installation path for binaries in the pkg-config setup, similarly to include and library directories.

Changes

File(s) Change Summary
zlib.pc.in, zlib.pc.cmakein Added bindir variable declaration to define the binary directory
CMakeLists.txt Added logic to set PC_BIN_INSTALL_DIR based on CMAKE_INSTALL_BINDIR

Suggested reviewers

  • Dead2
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0120631 and f05f1a7.

📒 Files selected for processing (3)
  • CMakeLists.txt (1 hunks)
  • zlib.pc.cmakein (1 hunks)
  • zlib.pc.in (1 hunks)
✅ Files skipped from review due to trivial changes (2)
  • zlib.pc.cmakein
  • CMakeLists.txt
🚧 Files skipped from review as they are similar to previous changes (1)
  • zlib.pc.in
⏰ Context from checks skipped due to timeout of 90000ms (50)
  • GitHub Check: Windows MSVC 2019 v140 Win32
  • GitHub Check: macOS GCC Symbol Prefix & Compat
  • GitHub Check: macOS GCC Symbol Prefix (ARM64)
  • GitHub Check: macOS GCC (ARM64)
  • GitHub Check: Ubuntu GCC RISCV64 No RVV
  • GitHub Check: Windows MSVC 2019 v140 Win32
  • GitHub Check: macOS GCC Symbol Prefix & Compat
  • GitHub Check: macOS GCC Symbol Prefix (ARM64)
  • GitHub Check: macOS GCC (ARM64)
  • GitHub Check: Ubuntu GCC RISCV64 No RVV
  • GitHub Check: Windows MSVC 2019 v140 Win32
  • GitHub Check: macOS GCC Symbol Prefix & Compat
  • GitHub Check: macOS GCC Symbol Prefix (ARM64)
  • GitHub Check: macOS GCC (ARM64)
  • GitHub Check: Ubuntu GCC RISCV64 No RVV
  • GitHub Check: Windows MSVC 2019 v140 Win32
  • GitHub Check: macOS GCC Symbol Prefix & Compat
  • GitHub Check: macOS GCC Symbol Prefix (ARM64)
  • GitHub Check: macOS GCC (ARM64)
  • GitHub Check: Ubuntu GCC RISCV64 No RVV
  • GitHub Check: Windows MSVC 2019 v140 Win32
  • GitHub Check: macOS GCC Symbol Prefix & Compat
  • GitHub Check: macOS GCC Symbol Prefix (ARM64)
  • GitHub Check: macOS GCC (ARM64)
  • GitHub Check: Ubuntu GCC RISCV64 No RVV
  • GitHub Check: Windows MSVC 2019 v140 Win32
  • GitHub Check: macOS GCC Symbol Prefix & Compat
  • GitHub Check: macOS GCC Symbol Prefix (ARM64)
  • GitHub Check: macOS GCC (ARM64)
  • GitHub Check: Ubuntu GCC RISCV64 No RVV
  • GitHub Check: Windows MSVC 2019 v140 Win32
  • GitHub Check: macOS GCC Symbol Prefix & Compat
  • GitHub Check: macOS GCC Symbol Prefix (ARM64)
  • GitHub Check: macOS GCC (ARM64)
  • GitHub Check: Ubuntu GCC RISCV64 No RVV
  • GitHub Check: Windows MSVC 2019 v140 Win32
  • GitHub Check: macOS GCC Symbol Prefix & Compat
  • GitHub Check: macOS GCC Symbol Prefix (ARM64)
  • GitHub Check: macOS GCC (ARM64)
  • GitHub Check: Ubuntu GCC RISCV64 No RVV
  • GitHub Check: Windows MSVC 2019 v140 Win32
  • GitHub Check: macOS GCC Symbol Prefix & Compat
  • GitHub Check: macOS GCC Symbol Prefix (ARM64)
  • GitHub Check: macOS GCC (ARM64)
  • GitHub Check: Ubuntu GCC RISCV64 No RVV
  • GitHub Check: Windows MSVC 2019 v140 Win32
  • GitHub Check: macOS GCC Symbol Prefix & Compat
  • GitHub Check: macOS GCC Symbol Prefix (ARM64)
  • GitHub Check: macOS GCC (ARM64)
  • GitHub Check: Ubuntu GCC RISCV64 No RVV

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

This was referenced Jun 6, 2025
Closed
Closed
@phprus
Add bindir into zlib.pc.in for compatibility with Cygwin and Msys2
f05f1a7 
Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>
@phprus phprus force-pushed the pkgconfig-msys2-1 branch from 0120631 to f05f1a7 Compare June 6, 2025 16:49
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 6, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.79%. Comparing base (2c98ece) to head (f05f1a7).
Report is 2 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1920      +/-   ##
===========================================
+ Coverage    81.78%   81.79%   +0.01%     
===========================================
  Files          147      147              
  Lines        13321    13321              
  Branches      2955     2955              
===========================================
+ Hits         10894    10896       +2     
  Misses        1511     1511              
+ Partials       916      914       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Dead2
Dead2 approved these changes Jun 12, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@Dead2 Dead2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dead2 Dead2 merged commit 617c852 into zlib-ng:develop Jun 16, 2025
141 of 146 checks passed
@Dead2 Dead2 mentioned this pull request Aug 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Dead2 Dead2 Dead2 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@phprus @Dead2