Fix 32bit large chorba by samrussell · Pull Request #1912 · zlib-ng/zlib-ng

samrussell · 2025-05-12T08:36:05Z

Fixes #1910

Tested on WSL/Ubuntu 24.04.1 gcc with --m32

Summary by CodeRabbit

Refactor
- Improved internal data processing by optimizing memory access to use 64-bit word operations for enhanced performance and consistency.
- Updated byte order handling and data copying methods to align with the new memory access approach.

No changes to user-facing features or functionality.

coderabbitai · 2025-05-12T08:36:11Z

"""

Walkthrough

The code refactors memory access in arch/generic/crc32_chorba_c.c by introducing explicit 64-bit pointer aliases for the bitbuffer and input arrays. All relevant pointer arithmetic and data accesses are updated to use these 64-bit pointers. The byte swap macro used for CRC initialization is changed from ZSWAP64 to ZSWAPWORD. No changes are made to control flow, error handling, or public interfaces.

Changes

File(s)	Change Summary
arch/generic/crc32_chorba_c.c	Added 64-bit pointer aliases for `bitbuffer` and `input`; updated all accesses to use them; replaced byte swap macro for CRC from `ZSWAP64` to `ZSWAPWORD`; modified `memcpy` to use new pointer arithmetic.

Sequence Diagram(s)

Not applicable: The changes are limited to pointer aliasing and memory access refactoring without introducing or modifying control flow or feature logic.

Assessment against linked issues

Objective	Addressed	Explanation
Fix CRC32 failures with 32-bit mingw32 builds in the chorba implementation (#1910)	✅

Possibly related PRs

Fix a big endian bug on the 32k and larger specializations of chorba #1891: Fixes a big endian bug in crc32_chorba_c.c by conditionally swapping CRC value with ZSWAP64; both PRs modify byte order handling and data access in Chorba CRC32 code.

Suggested labels

Architecture

Suggested reviewers

Dead2
"""

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ece19d6 and 1ab4bac.

📒 Files selected for processing (1)

arch/generic/crc32_chorba_c.c (4 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

arch/generic/crc32_chorba_c.c

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov · 2025-05-12T08:42:58Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.81%. Comparing base (f90c011) to head (1ab4bac).
Report is 2 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff              @@
##           develop    #1912       +/-   ##
============================================
+ Coverage    39.45%   81.81%   +42.36%     
============================================
  Files           74      147       +73     
  Lines         7883    13321     +5438     
  Branches      1303     2955     +1652     
============================================
+ Hits          3110    10899     +7789     
+ Misses        4532     1515     -3017     
- Partials       241      907      +666

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Dead2 · 2025-05-27T12:47:34Z

@samrussell Rebase please? So we can see that the CI succeeds.

nmoinvaz added the bug label May 12, 2025

Fix 32bit large chorba

1ab4bac

samrussell force-pushed the chorba_large_32bit_fix branch from ece19d6 to 1ab4bac Compare May 27, 2025 12:52

Dead2 approved these changes May 27, 2025

View reviewed changes

Dead2 merged commit 41d72b9 into zlib-ng:develop May 28, 2025
137 of 145 checks passed

coderabbitai bot mentioned this pull request Oct 2, 2025

Split CRC32 Braid and Chorba word types #1975

Merged

Dead2 mentioned this pull request Nov 5, 2025

2.3.0 RC1 #1994

Merged

This was referenced Nov 11, 2025

Reorganize Chorba activation and refactor Chorba dispatch #2003

Closed

Reorganize Chorba activation #2004

Merged

coderabbitai bot mentioned this pull request Dec 2, 2025

Chorba: Fix edge case bug for >256KB input #2033

Merged

coderabbitai bot mentioned this pull request Dec 19, 2025

Refactor crc32_fold functions into single crc32_copy #2048

Merged

coderabbitai bot mentioned this pull request Jan 7, 2026

Use GCC's may_alias attribute for access to buffers in crc32_chorba #2078

Merged

coderabbitai bot mentioned this pull request Jan 16, 2026

Replace conditional byte swapping with portable host/LE conversion #2105

Merged

coderabbitai bot mentioned this pull request Feb 18, 2026

Cleanup pointer style and parameter names in crc32 chorba functions #2162

Merged

coderabbitai bot mentioned this pull request Apr 3, 2026

Cleanup crc32 chorba #2241

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix 32bit large chorba#1912

Fix 32bit large chorba#1912
Dead2 merged 1 commit intozlib-ng:developfrom
samrussell:chorba_large_32bit_fix

samrussell commented May 12, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented May 12, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

codecov bot commented May 12, 2025 •

edited

Loading

Uh oh!

Dead2 commented May 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

samrussell commented May 12, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented May 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Assessment against linked issues

Possibly related PRs

Suggested labels

Suggested reviewers

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

codecov bot commented May 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Dead2 commented May 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

samrussell commented May 12, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented May 12, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented May 12, 2025 •

edited

Loading