Skip to content

Remove late enable_language calls.#1903

Merged
Dead2 merged 1 commit intozlib-ng:developfrom
phprus:cmake-cxx-1
Apr 14, 2025
Merged

Remove late enable_language calls.#1903
Dead2 merged 1 commit intozlib-ng:developfrom
phprus:cmake-cxx-1

Conversation

@phprus
Copy link
Copy Markdown
Contributor

@phprus phprus commented Apr 14, 2025 •
edited by coderabbitai bot
Loading

Cleanup after #1902

Summary by CodeRabbit

  • Chores
    • Revised the build configuration by removing explicit language activation commands for C and C++. This update affects how language-specific code is processed in scenarios like tests, benchmarks, and fuzzing, so users may need to verify that their build environments meet the necessary compilation requirements.

@phprus
Remove late enable_language calls.
55234d1 
Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 14, 2025 •
edited
Loading

Walkthrough

This pull request removes explicit commands to enable programming languages in several CMake configuration files. Specifically, it deletes the enable_language(C) call in the architecture detection script and removes the enable_language(CXX) calls in test-related CMakeLists files. The overall configuration logic remains unchanged, though the modifications may affect the default language setup during the build process.

Changes

File(s) Change Summary
cmake/detect-arch.cmake Removed enable_language(C) from the non-cross compiling section.
test/CMakeLists.txt, test/benchmarks/CMakeLists.txt, test/fuzz/CMakeLists.txt Removed enable_language(CXX) from conditional blocks, altering the explicit enabling of C++ support.

Possibly related PRs

Suggested reviewers

  • nmoinvaz

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)
  • We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between eb76eca and 55234d1.

📒 Files selected for processing (4)
  • cmake/detect-arch.cmake (0 hunks)
  • test/CMakeLists.txt (0 hunks)
  • test/benchmarks/CMakeLists.txt (0 hunks)
  • test/fuzz/CMakeLists.txt (0 hunks)
💤 Files with no reviewable changes (4)
  • test/benchmarks/CMakeLists.txt
  • cmake/detect-arch.cmake
  • test/fuzz/CMakeLists.txt
  • test/CMakeLists.txt
⏰ Context from checks skipped due to timeout of 90000ms (37)
  • GitHub Check: Windows MSVC 2022 v143 Win32
  • GitHub Check: Windows GCC Compat No Opt
  • GitHub Check: Ubuntu GCC S390X No vectorized CRC32
  • GitHub Check: macOS GCC
  • GitHub Check: Windows MSVC 2022 v143 Win32
  • GitHub Check: Windows GCC Compat No Opt
  • GitHub Check: Ubuntu GCC S390X No vectorized CRC32
  • GitHub Check: macOS GCC
  • GitHub Check: Windows MSVC 2022 v143 Win32
  • GitHub Check: Windows GCC Compat No Opt
  • GitHub Check: Ubuntu GCC S390X No vectorized CRC32
  • GitHub Check: macOS GCC
  • GitHub Check: Windows MSVC 2022 v143 Win32
  • GitHub Check: Windows GCC Compat No Opt
  • GitHub Check: Ubuntu GCC S390X No vectorized CRC32
  • GitHub Check: macOS GCC
  • GitHub Check: Windows MSVC 2022 v143 Win32
  • GitHub Check: Windows GCC Compat No Opt
  • GitHub Check: Ubuntu GCC S390X No vectorized CRC32
  • GitHub Check: macOS GCC
  • GitHub Check: Windows MSVC 2022 v143 Win32
  • GitHub Check: Windows GCC Compat No Opt
  • GitHub Check: Ubuntu GCC S390X No vectorized CRC32
  • GitHub Check: macOS GCC
  • GitHub Check: Windows MSVC 2022 v143 Win32
  • GitHub Check: Windows GCC Compat No Opt
  • GitHub Check: Ubuntu GCC S390X No vectorized CRC32
  • GitHub Check: macOS GCC
  • GitHub Check: Windows MSVC 2022 v143 Win32
  • GitHub Check: Windows GCC Compat No Opt
  • GitHub Check: macOS GCC
  • GitHub Check: Windows MSVC 2022 v143 Win32
  • GitHub Check: Windows GCC Compat No Opt
  • GitHub Check: macOS GCC
  • GitHub Check: Windows MSVC 2022 v143 Win32
  • GitHub Check: Windows GCC Compat No Opt
  • GitHub Check: macOS GCC

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 14, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.39%. Comparing base (eb76eca) to head (55234d1).
Report is 7 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff              @@
##           develop    #1903       +/-   ##
============================================
+ Coverage    40.68%   83.39%   +42.71%     
============================================
  Files           72      144       +72     
  Lines         7635    12948     +5313     
  Branches      1275     2857     +1582     
============================================
+ Hits          3106    10798     +7692     
+ Misses        4295     1196     -3099     
- Partials       234      954      +720

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Dead2
Dead2 approved these changes Apr 14, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@Dead2 Dead2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dead2 Dead2 merged commit ac1642f into zlib-ng:develop Apr 14, 2025
143 of 149 checks passed
@Dead2 Dead2 mentioned this pull request Aug 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Dead2 Dead2 Dead2 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@phprus @Dead2