Skip to content

[FreeBSD] Define _XOPEN_SOURCE for gtest_zlib#1900

Merged
Dead2 merged 1 commit intozlib-ng:developfrom
mtl1979:freebsd-isascii
Apr 14, 2025
Merged

[FreeBSD] Define _XOPEN_SOURCE for gtest_zlib#1900
Dead2 merged 1 commit intozlib-ng:developfrom
mtl1979:freebsd-isascii

Conversation

@mtl1979
Copy link
Copy Markdown
Collaborator

@mtl1979 mtl1979 commented Apr 10, 2025 •
edited by coderabbitai bot
Loading

  • Without defining _XOPEN_SOURCE as 700, isascii() is not available on FreeBSD 14.

Summary by CodeRabbit

  • Chores
    • Improved system compatibility on FreeBSD by refining internal configuration settings to ensure smoother builds on that platform. No visible functionality changes were introduced.

@mtl1979
[FreeBSD] Define _XOPEN_SOURCE for gtest_zlib
bc281ec 
* Without defining _XOPEN_SOURCE as 700, isascii() is not available on FreeBSD 14.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 10, 2025 •
edited
Loading

Walkthrough

The pull request updates the build configuration for FreeBSD systems by adding a conditional compilation option. When the system is detected as FreeBSD, it applies the compile flag -D_XOPEN_SOURCE=700 to the gtest_zlib target. The change is isolated to the CMake configuration and does not alter existing logic or public entity declarations.

Changes

File Change Summary
test/CMakeLists.txt Added a conditional block to apply the -D_XOPEN_SOURCE=700 compile option to the gtest_zlib target on FreeBSD systems.

Sequence Diagram(s)

sequenceDiagram
    participant CMake
    participant System
    participant Target

    System->>CMake: Provide system name ("FreeBSD")
    CMake->>CMake: Evaluate condition (if FreeBSD)
    CMake->>Target: Apply compile option (-D_XOPEN_SOURCE=700)
Loading
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e4a31e0 and bc281ec.

📒 Files selected for processing (1)
  • test/CMakeLists.txt (1 hunks)
🔇 Additional comments (1)
test/CMakeLists.txt (1)

208-211: Appropriate FreeBSD-specific compile option addition
The added conditional block correctly detects FreeBSD via CMAKE_SYSTEM_NAME and applies the compile option -D_XOPEN_SOURCE=700 to the gtest_zlib target. This change effectively addresses the issue of making isascii() available on FreeBSD 14 without impacting other platforms.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.41%. Comparing base (e4a31e0) to head (bc281ec).
Report is 5 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1900      +/-   ##
===========================================
- Coverage    83.42%   83.41%   -0.01%     
===========================================
  Files          144      144              
  Lines        12948    12948              
  Branches      2857     2857              
===========================================
- Hits         10802    10801       -1     
+ Misses        1202     1195       -7     
- Partials       944      952       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Dead2
Dead2 approved these changes Apr 14, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@Dead2 Dead2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dead2 Dead2 merged commit 19b3b7f into zlib-ng:develop Apr 14, 2025
145 of 150 checks passed
@Dead2 Dead2 mentioned this pull request Aug 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nmoinvaz nmoinvaz nmoinvaz approved these changes

@Dead2 Dead2 Dead2 approved these changes

Assignees

No one assigned

Labels

Build Env

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mtl1979 @nmoinvaz @Dead2