Merged
Conversation
Contributor
WalkthroughThe pull request removes all components related to the NMake build system. This includes deletion of the GitHub Actions workflow for NMake, multiple Makefiles designed for building the zlib library on Windows (targeting various architectures), and associated utility scripts (a dependency checker and a replacement script). In addition, the README documentation has been updated to eliminate the CI badge and textual references to NMake support. Changes
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (7)
💤 Files with no reviewable changes (6)
⏰ Context from checks skipped due to timeout of 90000ms (130)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Reduce development burden by getting rid of NMake files that are manually kept up to date. For continued NMake support please generate NMake project files using CMake.
014128e to
b4b34ec
Compare
Member
Author
|
This gets rid of 7 CI checks so that is great, and on Windows which is slower. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1899 +/- ##
===========================================
- Coverage 83.42% 83.41% -0.01%
===========================================
Files 144 144
Lines 12948 12948
Branches 2857 2857
===========================================
- Hits 10802 10801 -1
- Misses 1202 1203 +1
Partials 944 944 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mtl1979
approved these changes
Apr 10, 2025
Collaborator
mtl1979
left a comment
There was a problem hiding this comment.
LGTM... This was planned a long time ago.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce development burden by getting rid of NMake files that are manually kept up to date. For continued NMake support please generate NMake project files using CMake.
Summary by CodeRabbit
Documentation
Chores