Remove deprecated ubuntu-20.04 image from CI.#1898
Conversation
WalkthroughThis pull request updates the GitHub Actions workflows by removing outdated Ubuntu 20.04 configurations and transitioning to the latest Ubuntu environment. Specifically, it removes the "Ubuntu 20.04 GCC" and "Ubuntu 20.04 Clang 6" jobs from the appropriate workflow files, updates the environment in remaining jobs (switching to Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant GH as GitHub Actions
participant W1 as cmake.yml Workflow
participant W2 as configure.yml Workflow
U->>GH: Push commit (trigger CI)
GH->>W1: Execute cmake.yml workflow
W1->>W1: Remove obsolete Ubuntu 20.04 GCC and Clang 6 jobs
W1->>W1: Update PPC64LE and SPARC64 jobs to use ubuntu-latest
W1->>W1: Apply updated CMake args and package lists
W1->>W1: Set environment variable CXXFLAGS
GH->>W2: Execute configure.yml workflow
W2->>W2: Remove Ubuntu 20.04 GCC job configuration
Possibly related PRs
Suggested labels
Suggested reviewers
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/cmake.yml (1)
721-721: Inclusion of the CXXFLAGS Environment VariableAdding
CXXFLAGS: ${{ matrix.cxxflags }}in the environment settings ensures that C++ build flags are properly propagated during project file generation. It would be beneficial to confirm thatmatrix.cxxflagsis defined in all relevant matrix configurations or to include a sensible default if not.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/cmake.yml(3 hunks).github/workflows/configure.yml(0 hunks)
💤 Files with no reviewable changes (1)
- .github/workflows/configure.yml
🔇 Additional comments (2)
.github/workflows/cmake.yml (2)
277-284: Update OS and Package Configuration for Ubuntu GCC PPC64LE JobThe changes correctly update the operating system to
ubuntu-latestand adjust the toolchain arguments and package list. The inclusion of a specific comment about the GTest illegal instruction and the architecture flag (-mcpu=power8) helps clarify the context for testing on Power8. Please verify that these settings and the toolchain file (cmake/toolchain-powerpc64le.cmake) remain fully compatible with the updated environment.
307-309: Verify the Ubuntu GCC SPARC64 Job AdjustmentsThe OS has been updated to
ubuntu-latestand the packages list has been modified (notably, adjusting the dependencies by potentially removing outdated packages). Please ensure that the SPARC64 toolchain (withcmake/toolchain-sparc64.cmake) and the updated packages remain valid in the new Ubuntu environment.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1898 +/- ##
============================================
+ Coverage 42.10% 83.44% +41.33%
============================================
Files 71 144 +73
Lines 7353 12948 +5595
Branches 1265 2857 +1592
============================================
+ Hits 3096 10804 +7708
+ Misses 4035 1194 -2841
- Partials 222 950 +728 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Looks good, apparently there is no |
Summary by CodeRabbit