Fix alignment issues on 32 bit iOS by Un1q32 · Pull Request #1869 · zlib-ng/zlib-ng

Un1q32 · 2025-02-11T17:53:28Z

Just extends the Android fix to also apply to iOS

Summary by CodeRabbit

Bug Fixes
- Enhanced platform compatibility by updating conditions for hardware optimizations, ensuring a consistent and stable experience on iOS devices.

coderabbitai · 2025-02-11T17:53:36Z

Walkthrough

This pull request updates the preprocessor conditional in the ARM NEON intrinsics header file. The condition, originally targeting Clang on 32-bit Android, is extended to include iOS. No changes were made to any function implementations or public declarations.

Changes

File	Changes
`arch/arm/neon_intrins.h`	Expanded Clang conditional to include iOS along with 32-bit Android.

Assessment against linked issues

Objective	Addressed	Explanation
Fix SIGBUS crash on armv6 iOS (#1842)	✅

Suggested labels

Build Env, Architecture

Suggested reviewers

Dead2

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 860e4cf and 68d9a89.

📒 Files selected for processing (1)

arch/arm/neon_intrins.h (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (30)

GitHub Check: EL9 Clang S390X DFLTCC MSAN
GitHub Check: macOS Clang Symbol Prefix
GitHub Check: macOS Clang
GitHub Check: EL9 Clang S390X DFLTCC MSAN
GitHub Check: macOS Clang Symbol Prefix
GitHub Check: macOS Clang
GitHub Check: EL9 Clang S390X DFLTCC MSAN
GitHub Check: macOS Clang Symbol Prefix
GitHub Check: macOS Clang
GitHub Check: EL9 Clang S390X DFLTCC MSAN
GitHub Check: macOS Clang Symbol Prefix
GitHub Check: macOS Clang
GitHub Check: EL9 Clang S390X DFLTCC MSAN
GitHub Check: macOS Clang Symbol Prefix
GitHub Check: macOS Clang
GitHub Check: EL9 Clang S390X DFLTCC MSAN
GitHub Check: macOS Clang Symbol Prefix
GitHub Check: macOS Clang
GitHub Check: EL9 Clang S390X DFLTCC MSAN
GitHub Check: macOS Clang Symbol Prefix
GitHub Check: macOS Clang
GitHub Check: EL9 Clang S390X DFLTCC MSAN
GitHub Check: macOS Clang Symbol Prefix
GitHub Check: macOS Clang
GitHub Check: EL9 Clang S390X DFLTCC MSAN
GitHub Check: macOS Clang Symbol Prefix
GitHub Check: macOS Clang
GitHub Check: EL9 Clang S390X DFLTCC MSAN
GitHub Check: macOS Clang Symbol Prefix
GitHub Check: macOS Clang

🔇 Additional comments (1)

arch/arm/neon_intrins.h (1)

28-29: LGTM! Good catch on extending the alignment fix to iOS.

The change correctly extends the workaround for strict alignment requirements to 32-bit iOS, following the same pattern that worked for Android. The preprocessor condition and comment accurately reflect both affected platforms.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

phprus · 2025-02-11T18:10:02Z

arch/arm/neon_intrins.h

-#  if defined(__clang__) && defined(__arm__) && defined(__ANDROID__)
-/* Clang for 32-bit Android has too strict alignment requirement (:256) for x4 NEON intrinsics */
+#  if defined(__clang__) && defined(__arm__) && (defined(__ANDROID__) || defined(__APPLE__))
+/* Clang for 32-bit Android and iOS has too strict alignment requirement (:256) for x4 NEON intrinsics */


Maybe use __ENVIRONMENT_IPHONE_OS_VERSION_MIN_REQUIRED__ instead of __APPLE__, because __APPLE__ is defined on macOS too.

__arm__ being defined is also required, so I don't think it's an issue since there is no 32 bit arm macOS.

codecov · 2025-02-11T18:22:52Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.39%. Comparing base (860e4cf) to head (68d9a89).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1869      +/-   ##
===========================================
- Coverage    80.44%   80.39%   -0.06%     
===========================================
  Files          139      139              
  Lines        11176    11176              
  Branches      2867     2867              
===========================================
- Hits          8991     8985       -6     
+ Misses        1221     1220       -1     
- Partials       964      971       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

neheb · 2025-02-11T22:45:17Z

I'd remove the ANDROID and APPLE defines. This code works nowhere:

#1844 (comment)

Un1q32 · 2025-02-11T23:18:07Z

Closing in favor of #1824

fix alignment issues on 32 bit iOS

68d9a89

phprus reviewed Feb 11, 2025

View reviewed changes

Dead2 mentioned this pull request Feb 11, 2025

Fix Clang arm32 build #1824

Closed

Un1q32 closed this Feb 11, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix alignment issues on 32 bit iOS#1869

Fix alignment issues on 32 bit iOS#1869
Un1q32 wants to merge 1 commit intozlib-ng:developfrom
Un1q32:develop

Un1q32 commented Feb 11, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Feb 11, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

phprus Feb 11, 2025

Uh oh!

Un1q32 Feb 11, 2025

Uh oh!

codecov bot commented Feb 11, 2025 •

edited

Loading

Uh oh!

neheb commented Feb 11, 2025

Uh oh!

Un1q32 commented Feb 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Un1q32 commented Feb 11, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Feb 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Assessment against linked issues

Suggested labels

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

phprus Feb 11, 2025

Choose a reason for hiding this comment

Uh oh!

Un1q32 Feb 11, 2025

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Feb 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

neheb commented Feb 11, 2025

Uh oh!

Un1q32 commented Feb 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Un1q32 commented Feb 11, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 11, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented Feb 11, 2025 •

edited

Loading