Proposal: Improve include directories#1855
Merged
Dead2 merged 2 commits intozlib-ng:developfrom Jan 27, 2025
Merged
Conversation
Contributor
WalkthroughThis pull request involves modifications to build configuration files and header files, primarily focusing on include paths and header guards. The changes span across Changes
Possibly related PRs
Suggested labels
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (4)
💤 Files with no reviewable changes (1)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms (48)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1855 +/- ##
========================================
Coverage 80.34% 80.35%
========================================
Files 138 138
Lines 11147 11147
Branches 2860 2860
========================================
+ Hits 8956 8957 +1
+ Misses 1217 1216 -1
Partials 974 974 ☔ View full report in Codecov by Sentry. |
Collaborator
|
Using |
…th "fallback_builtins.h" in zlib-ng sources directory Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>
Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>
Contributor
Author
|
@mtl1979 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal
Rename
arch/power/fallback_builtins.hto avoid possible conflict withfallback_builtins.hin zlib-ng sources directoryfind . -name fallback_builtins.h ./fallback_builtins.h ./arch/power/fallback_builtins.hRemove unused include directories
#include "name.h"file search order:If we compile an arch-specific sources, the header files will be in the same arch-specific directory.
Arch-independent code should not accidentally include arch-specific header files.
Summary by CodeRabbit
Refactor
Chores
The changes primarily involve internal build system and header file modifications with no direct end-user impact.