Skip to content

Workaround error G6E97C40B with RVV#1853

Merged
Dead2 merged 1 commit intozlib-ng:developfrom
dkurt:patch-1
Jan 19, 2025
Merged

Workaround error G6E97C40B with RVV#1853
Dead2 merged 1 commit intozlib-ng:developfrom
dkurt:patch-1

Conversation

@dkurt
Copy link
Copy Markdown
Contributor

@dkurt dkurt commented Jan 15, 2025 •
edited by coderabbitai bot
Loading

Warning as an error with GCC from Uubuntu 24.04:

/home/runner/work/dotnet_riscv/dotnet_riscv/runtime/src/native/external/zlib-ng/arch/riscv/riscv_features.c(25,33): error G6E97C40B: suggest parentheses around ‘&&’ within ‘||’ [-Wparentheses] [/home/runner/work/dotnet_riscv/dotnet_riscv/runtime/src/native/libs/build-native.proj]

Summary by CodeRabbit

  • Style
    • Improved readability of kernel version comparison logic by adding parentheses to clarify the logical expression
    • No functional changes to the code's behavior

@dkurt
Workaround error G6E97C40B
cb73d74 
Warning as an error with GCC from Uubuntu 24.04:
```
/home/runner/work/dotnet_riscv/dotnet_riscv/runtime/src/native/external/zlib-ng/arch/riscv/riscv_features.c(25,33): error G6E97C40B: suggest parentheses around ‘&&’ within ‘||’ [-Wparentheses] [/home/runner/work/dotnet_riscv/dotnet_riscv/runtime/src/native/libs/build-native.proj]
```
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Jan 15, 2025 •
edited
Loading

Walkthrough

The pull request involves a minor modification to the is_kernel_version_greater_or_equal_to_6_5 function in the arch/riscv/riscv_features.c file. The change adds parentheses to the existing conditional logic, which improves the readability of the code without altering its fundamental behavior. The modification ensures a clearer representation of the logical conditions for checking kernel version compatibility.

Changes

File Change Summary
arch/riscv/riscv_features.c Added parentheses to clarify logical condition in version comparison

Suggested Reviewers

  • Dead2
  • nmoinvaz
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 787c7f6 and cb73d74.

📒 Files selected for processing (1)
  • arch/riscv/riscv_features.c (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • arch/riscv/riscv_features.c

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@dkurt dkurt changed the title Workaround error G6E97C40B Workaround error G6E97C40B with RVV Jan 15, 2025
@Dead2 Dead2 merged commit 9064a25 into zlib-ng:develop Jan 19, 2025
@dkurt dkurt deleted the patch-1 branch January 20, 2025 04:40
@Dead2 Dead2 mentioned this pull request Feb 9, 2025
Merged
@coderabbitai coderabbitai bot mentioned this pull request Jan 31, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nmoinvaz nmoinvaz nmoinvaz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dkurt @nmoinvaz @Dead2