Skip to content

[CI] Don't try to use macOS 11 as it's no longer supported.#1790

Merged
Dead2 merged 1 commit intozlib-ng:developfrom
mtl1979:pkgcheck-macos
Sep 20, 2024
Merged

[CI] Don't try to use macOS 11 as it's no longer supported.#1790
Dead2 merged 1 commit intozlib-ng:developfrom
mtl1979:pkgcheck-macos

Conversation

@mtl1979
Copy link
Copy Markdown
Collaborator

@mtl1979 mtl1979 commented Sep 18, 2024

  • Add support for Apple M1 in pkgcheck

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (develop@efca012). Learn more about missing BASE report.
Report is 2 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #1790   +/-   ##
==========================================
  Coverage           ?   33.33%           
==========================================
  Files              ?       66           
  Lines              ?     5504           
  Branches           ?     1227           
==========================================
  Hits               ?     1835           
  Misses             ?     3410           
  Partials           ?      259           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtl1979 mtl1979 marked this pull request as ready for review September 18, 2024 22:35
Copy link
Copy Markdown
Member

@Dead2 Dead2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nmoinvaz
Copy link
Copy Markdown
Member

Is the ZERO_AR_DATE thing no longer and issue on the newer SDK?

@mtl1979
Copy link
Copy Markdown
Collaborator Author

mtl1979 commented Sep 19, 2024

Is the ZERO_AR_DATE thing no longer and issue on the newer SDK?

I tried few different SDK versions and this one was first one to pass... Not sure if it's because of switch to AArch64 or generic fix in toolchain... With previous SDK version it would fail long before ar was even used.

@Dead2 Dead2 merged commit 8e19f15 into zlib-ng:develop Sep 20, 2024
@Dead2 Dead2 mentioned this pull request Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants