Allow overridde CMAKE_CXX_* variables and fix overridde CMAKE_C_*#1787
Merged
Dead2 merged 2 commits intozlib-ng:developfrom Sep 18, 2024
Merged
Allow overridde CMAKE_CXX_* variables and fix overridde CMAKE_C_*#1787Dead2 merged 2 commits intozlib-ng:developfrom
Dead2 merged 2 commits intozlib-ng:developfrom
Conversation
…E_CXX_EXTENSIONS variables for tests and benchmarks. Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>
…TENSIONS. False value is allowed for CMAKE_C_STANDARD_REQUIRED and CMAKE_C_EXTENSIONS. Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1787 +/- ##
===========================================
- Coverage 33.39% 33.28% -0.11%
===========================================
Files 66 66
Lines 5504 5504
Branches 1227 1227
===========================================
- Hits 1838 1832 -6
Misses 3418 3418
- Partials 248 254 +6 ☔ View full report in Codecov by Sentry. |
Dead2
approved these changes
Sep 17, 2024
Contributor
|
Hi, thanks for your work. I can build zlib-ng successfully on ArchLinux. However, I cannot build it successfully on OpenSUSE Tumbleweed. ArchLinux's gtest package contains while OpenSUSE Tumbleweed doesn't. On OpenSUSE, CMake finds gtest by MODULE which doesn't define |
Collaborator
|
@FantasqueX Finding by module is deprecated, so the issue should be reported to OpenSuSE packager. |
Contributor
|
I have issued a bug report to OpenSUSE https://bugzilla.opensuse.org/show_bug.cgi?id=1232917 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issue #1785
Allow overridde
CMAKE_CXX_*.Define
CMAKE_C_*variables only if it is not defined instead of if it areFalse.