Use target include instead of raw include#1784
Merged
Dead2 merged 1 commit intozlib-ng:developfrom Sep 20, 2024
Merged
Conversation
01afb09 to
120e5b5
Compare
Member
|
I'm not sure about removing |
Contributor
Author
The code above does the same thing as |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1784 +/- ##
============================================
- Coverage 83.34% 32.47% -50.87%
============================================
Files 132 66 -66
Lines 10019 5497 -4522
Branches 2687 1209 -1478
============================================
- Hits 8350 1785 -6565
- Misses 1010 3479 +2469
+ Partials 659 233 -426 ☔ View full report in Codecov by Sentry. |
nmoinvaz
approved these changes
Sep 17, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMake recommends using
target_include_directoriesinstead ofinclude_directories. https://cmake.org/cmake/help/latest/command/include_directories.htmlSome downstream projects such as opencv integrate zlib-ng to their source code. In those cases, less
include_directoriesis better.