Don't use chunkunroll for inflateBack#1773
Merged
Dead2 merged 1 commit intozlib-ng:developfrom Sep 11, 2024
Merged
Conversation
If the output buffer and the window buffer are the same memory allocation, we cannot make the assumptions that chunkunroll does, that it is okay to overwrite the output buffer.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1773 +/- ##
===========================================
- Coverage 83.33% 82.92% -0.41%
===========================================
Files 132 135 +3
Lines 10018 10306 +288
Branches 2687 2702 +15
===========================================
+ Hits 8348 8546 +198
- Misses 1009 1066 +57
- Partials 661 694 +33 ☔ View full report in Codecov by Sentry. |
|
thanks, tested locally and it solves the issue I've reported |
This was referenced Sep 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the output buffer and the window buffer are the same memory allocation, we cannot make the assumptions that
chunkunrolldoes, that it is okay to overwrite the output buffer.Fixes #1772