Fix new Windows SDK build break#1771
Merged
Dead2 merged 2 commits intozlib-ng:developfrom Sep 1, 2024
Merged
Conversation
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1771 +/- ##
===========================================
- Coverage 83.02% 83.01% -0.01%
===========================================
Files 135 135
Lines 10310 10310
Branches 2785 2785
===========================================
- Hits 8560 8559 -1
+ Misses 1057 1054 -3
- Partials 693 697 +4 ☔ View full report in Codecov by Sentry. |
Collaborator
|
|
Contributor
Author
|
I think that would work since the problematic defines are coming from |
nmoinvaz
approved these changes
Aug 29, 2024
Dead2
approved these changes
Aug 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream port of @jkotas' dotnet/runtime#106578.
dotnet/runtime#106578 (comment)