Skip to content

Silence possible loss of data warning in crc32_braid ZSWAPWORD call#1764

Merged
Dead2 merged 1 commit intozlib-ng:developfrom
nmoinvaz:fixes/crc32-cast
Aug 9, 2024
Merged

Silence possible loss of data warning in crc32_braid ZSWAPWORD call#1764
Dead2 merged 1 commit intozlib-ng:developfrom
nmoinvaz:fixes/crc32-cast

Conversation

@nmoinvaz
Copy link
Copy Markdown
Member

@nmoinvaz nmoinvaz commented Aug 5, 2024

MSVC

Warning	C4244
'=': conversion from 'z_word_t' to 'uint32_t', possible loss of data zlib
crc32_braid_c.c	195

Warning	C4244
'=': conversion from 'z_word_t' to 'uint32_t', possible loss of data
zlib
crc32_braid_c.c	195
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.01%. Comparing base (d54e376) to head (6b227ce).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1764   +/-   ##
========================================
  Coverage    83.01%   83.01%           
========================================
  Files          135      135           
  Lines        10291    10288    -3     
  Branches      2783     2782    -1     
========================================
- Hits          8543     8541    -2     
- Misses        1051     1052    +1     
+ Partials       697      695    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Member

@Dead2 Dead2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dead2 Dead2 merged commit 3de6c30 into zlib-ng:develop Aug 9, 2024
This was referenced Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants