Skip to content

[CI] Upgrade MacOS ARM64 UBSAN to use gcc-13.#1763

Merged
Dead2 merged 1 commit intozlib-ng:developfrom
mtl1979:macos-ubsan-arm64
Aug 9, 2024
Merged

[CI] Upgrade MacOS ARM64 UBSAN to use gcc-13.#1763
Dead2 merged 1 commit intozlib-ng:developfrom
mtl1979:macos-ubsan-arm64

Conversation

@mtl1979
Copy link
Copy Markdown
Collaborator

@mtl1979 mtl1979 commented Jul 30, 2024

  • GCC 12.4 and 13.3 are minimum supported due to GCC bug #114007; prefer GCC 13.3
  • gcovr 7.x is required for parsing coverage output of GCC 13.x; gcovr 7.2 is currently latest

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.00%. Comparing base (d54e376) to head (fdcb297).

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1763      +/-   ##
===========================================
- Coverage    83.01%   83.00%   -0.01%     
===========================================
  Files          135      135              
  Lines        10291    10292       +1     
  Branches      2783     2784       +1     
===========================================
  Hits          8543     8543              
  Misses        1051     1051              
- Partials       697      698       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dead2
Copy link
Copy Markdown
Member

Dead2 commented Aug 3, 2024

Does this fix need to go to the macOS package check as well? I am unable to get github actions to find a runner to pick up those jobs at all. Not sure why, there doesn't seem to be any indications as to why it is stuck like that.
I have cancelled and restarted those jobs multiple times over several days, no change.

@mtl1979
Copy link
Copy Markdown
Collaborator Author

mtl1979 commented Aug 3, 2024

Does this fix need to go to the macOS package check as well? I am unable to get github actions to find a runner to pick up those jobs at all. Not sure why, there doesn't seem to be any indications as to why it is stuck like that.
I have cancelled and restarted those jobs multiple times over several days, no change.

Some of the runners seem offline... I haven't checked yet if someone has reported the outage yet or if it's scheduled maintenance...

@phprus
Copy link
Copy Markdown
Contributor

phprus commented Aug 3, 2024 •
edited
Loading

@Dead2 , @mtl1979
macos-11 removed from github actions: actions/runner-images#10198

macos-11 zlib-ng issue: #1693

@mtl1979
Copy link
Copy Markdown
Collaborator Author

mtl1979 commented Aug 4, 2024

@Dead2 , @mtl1979
macos-11 removed from github actions: actions/runner-images#10198

macos-11 zlib-ng issue: #1693

I knew they were planning to remove it, just didn't remember the date.

Dead2
Dead2 approved these changes Aug 7, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@Dead2 Dead2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dead2 Dead2 merged commit 38037a0 into zlib-ng:develop Aug 9, 2024
This was referenced Sep 15, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nmoinvaz nmoinvaz nmoinvaz approved these changes

@Dead2 Dead2 Dead2 approved these changes

Assignees

No one assigned

Labels

Continuous Integration

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mtl1979 @Dead2 @phprus @nmoinvaz