Skip to content

Make use of unaligned loads on big endian in insert_string#1695

Merged
Dead2 merged 1 commit intozlib-ng:developfrom
ccawley2011:big-endian-insert-string
Sep 15, 2024
Merged

Make use of unaligned loads on big endian in insert_string#1695
Dead2 merged 1 commit intozlib-ng:developfrom
ccawley2011:big-endian-insert-string

Conversation

@ccawley2011
Copy link
Copy Markdown
Contributor

PR #1690 is required for this to take effect.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.03%. Comparing base (93b870f) to head (0d7522b).
Report is 65 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1695      +/-   ##
===========================================
- Coverage    83.03%   83.03%   -0.01%     
===========================================
  Files          134      134              
  Lines        10336    10336              
  Branches      2813     2812       -1     
===========================================
- Hits          8583     8582       -1     
- Misses        1054     1058       +4     
+ Partials       699      696       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nmoinvaz nmoinvaz added the Architecture Architecture specific label Mar 3, 2024
@nmoinvaz
Copy link
Copy Markdown
Member

@Dead2 I'm not sure why there has been no activity on this one. It LGTM.

@Dead2
Copy link
Copy Markdown
Member

Dead2 commented Sep 11, 2024

@nmoinvaz The PR description says it depends on #1690, so I have not questioned that. But it does look like it would be useful on its own as well, doesn't it?

@nmoinvaz
Copy link
Copy Markdown
Member

Yeah it does.

@ccawley2011
Copy link
Copy Markdown
Contributor Author

The reason for needing PR #1690 is because without it, the only architectures that define UNALIGNED_OK are little endian. This can still be merged without it, it just won't get covered by tests until PR #1690 is merged.

@Dead2 Dead2 merged commit c327d18 into zlib-ng:develop Sep 15, 2024
@Dead2 Dead2 mentioned this pull request Sep 15, 2024
@ccawley2011 ccawley2011 deleted the big-endian-insert-string branch July 9, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Architecture Architecture specific

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants