Ensure that unaligned compare256 variants are only used on little endian systems#1469
Merged
Dead2 merged 1 commit intozlib-ng:developfrom Apr 25, 2023
Merged
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #1469 +/- ##
===========================================
- Coverage 83.15% 83.13% -0.02%
===========================================
Files 130 130
Lines 10759 10759
Branches 2760 2760
===========================================
- Hits 8947 8945 -2
- Misses 1137 1139 +2
Partials 675 675
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Member
|
This check should be moved to |
Contributor
Author
There's already a check there - the reason for this PR is that not all places that check |
Dead2
approved these changes
Apr 23, 2023
Member
|
@ccawley2011 If you want to make a backport PR against stable as well, I can accept that as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change it should be possible to enable
UNALIGNED_OKon big endian PowerPC targets, although I've only been able to test this with QEMU.