Provide a Group::try_from_rng#59
Merged
str4d merged 1 commit intozkcrypto:release-0.14.0from Apr 16, 2025
Merged
Conversation
This was referenced Mar 10, 2025
str4d
reviewed
Apr 16, 2025
| /// this group. | ||
| /// | ||
| /// This function is non-deterministic, and samples from the user-provided RNG. | ||
| fn try_from_rng<R: TryRngCore + ?Sized>(rng: &mut R) -> Result<Self, R::Error>; |
Member
There was a problem hiding this comment.
Having trouble rebasing because the substantive change ended up in a merge commit which doesn't survive rebases.
b0d6ea4 to
4456de8
Compare
str4d
approved these changes
Apr 16, 2025
Member
str4d
left a comment
There was a problem hiding this comment.
utACK 4456de8
As with #57 (review), this change will need to go through a zkcrypto RFC before we cut the final 0.14.0 release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is stacked on: