Add Group::mul_by_generator#44
Conversation
Adds a provided method to the `Group` trait for performing multiplication by the generator. The use case is overriding this method in the event that precomputed scalar multiplication tables are available, which may be conditional depending on crate features like `alloc` or feature-gated static precomputed tables.
str4d
left a comment
There was a problem hiding this comment.
ACK, thanks!
This is adding a provided method to a trait, which is a possibly-breaking change. Per existing precedent for these crates, I consider it a minor change, so we can push this out with a point release. I will hold off merging this PR however until the other bugfix PRs are ready so I can determine what the content of the next release will be.
|
Re-linking #45 here because I'd forgotten about that issue, and it is relevant to whether we merge this PR. |
|
The use case described in #45 was a generator stored as |
|
@str4d this one should be good to go as well, I think |
|
Yeah, I'm inclined to include this in the 0.14.0 RFC for feedback, as #45 hasn't resolved and meanwhile |
Adds a provided method to the
Grouptrait for performing multiplication by the generator.The use case is overriding this method in the event that precomputed scalar multiplication tables are available, which may be conditional depending on crate features like
allocor feature-gated static precomputed tables.