Skip to content

Fix issues flagged by flutter analyze#45

Merged
zjs81 merged 1 commit into
zjs81:mainfrom
mtlynch:flutter-analyze
Jan 17, 2026
Merged

Fix issues flagged by flutter analyze#45
zjs81 merged 1 commit into
zjs81:mainfrom
mtlynch:flutter-analyze

Conversation

@mtlynch

@mtlynch mtlynch commented Jan 17, 2026

Copy link
Copy Markdown
Contributor

This fixes code quality issues that flutter analyze catches and adds a CI step to Github Actions to flag on any future issues.

Here was the full list of original issues flutter flagged:

$ flutter analyze
...
Analyzing meshcore-open...                                              

   info • Unnecessary braces in a string interpolation •
          lib/connector/meshcore_connector.dart:1769:36 • unnecessary_brace_in_string_interps
warning • The value of the local variable 'isFlood' isn't used •
       lib/connector/meshcore_connector.dart:2275:13 • unused_local_variable
   info • 'AESFastEngine' is deprecated and shouldn't be used. Has side-channel issues •
          lib/connector/meshcore_connector.dart:2621:35 • deprecated_member_use
warning • The declaration '_routeDirect' isn't referenced •
       lib/connector/meshcore_connector.dart:2995:11 • unused_element
   info • Statements in an if should be enclosed in a block • lib/screens/map_screen.dart:392:9 •
          curly_braces_in_flow_control_structures
   info • 'value' is deprecated and shouldn't be used. Use initialValue instead. This will set the
          initial value for the form field. This feature was deprecated after v3.33.0-1.0.pre •
          lib/screens/repeater_settings_screen.dart:898:15 • deprecated_member_use
   info • 'value' is deprecated and shouldn't be used. Use initialValue instead. This will set the
          initial value for the form field. This feature was deprecated after v3.33.0-1.0.pre •
          lib/screens/repeater_settings_screen.dart:920:15 • deprecated_member_use
   info • 'value' is deprecated and shouldn't be used. Use initialValue instead. This will set the
          initial value for the form field. This feature was deprecated after v3.33.0-1.0.pre •
          lib/screens/repeater_settings_screen.dart:942:15 • deprecated_member_use
warning • Unused import: 'dart:convert' • lib/screens/telemetry_screen.dart:2:8 • unused_import
warning • Unused import: 'dart:math' • lib/screens/telemetry_screen.dart:3:8 • unused_import
   info • The import of 'dart:typed_data' is unnecessary because all of the used elements are also
          provided by the import of 'package:flutter/foundation.dart' •
          lib/screens/telemetry_screen.dart:4:8 • unnecessary_import
warning • The value of the field '_timeEstment' isn't used • lib/screens/telemetry_screen.dart:37:7 •
       unused_field
   info • Don't use 'BuildContext's across async gaps • lib/screens/telemetry_screen.dart:73:31 •
          use_build_context_synchronously
warning • This case is covered by the previous cases • lib/services/ble_debug_log_service.dart:140:7
       • unreachable_switch_case
warning • This case is covered by the previous cases • lib/services/ble_debug_log_service.dart:142:7
       • unreachable_switch_case
warning • This case is covered by the previous cases • lib/services/ble_debug_log_service.dart:144:7
       • unreachable_switch_case
warning • This case is covered by the previous cases • lib/services/ble_debug_log_service.dart:146:7
       • unreachable_switch_case
warning • This case is covered by the previous cases • lib/services/ble_debug_log_service.dart:148:7
       • unreachable_switch_case
warning • This case is covered by the previous cases • lib/services/ble_debug_log_service.dart:150:7
       • unreachable_switch_case
warning • This case is covered by the previous cases • lib/services/ble_debug_log_service.dart:152:7
       • unreachable_switch_case
warning • This case is covered by the previous cases • lib/services/ble_debug_log_service.dart:154:7
       • unreachable_switch_case
warning • This case is covered by the previous cases • lib/services/ble_debug_log_service.dart:156:7
       • unreachable_switch_case
warning • This case is covered by the previous cases • lib/services/ble_debug_log_service.dart:158:7
       • unreachable_switch_case
warning • This case is covered by the previous cases • lib/services/ble_debug_log_service.dart:160:7
       • unreachable_switch_case
warning • The value of the field '_storage' isn't used •
       lib/services/message_retry_service.dart:39:24 • unused_field

25 issues found. (ran in 2.6s)

This fixes code quality issues that flutter analyze catches and adds a CI step to Github Actions to flag on any future issues.
@zjs81 zjs81 merged commit 06fc08c into zjs81:main Jan 17, 2026
@zjs81

zjs81 commented Jan 17, 2026

Copy link
Copy Markdown
Owner

Thank you just merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants