Show repeater login error in login dialog#41
Merged
Conversation
Contributor
|
German translation of the changes are correct. 👍 |
Owner
|
Nice job just merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the repeater login dialog, if the login fails, the error is bubbled up as an Exception and displayed as a temporary snackbar notice behind the foreground dialog, making it difficult for the user to see. Also, the fact that it's an Exception means that it doesn't get localized to other languages other than English.
This change turns the login failure Exception into standard text in the login dialog and localizes it to support every language.
Before
After
Note
I used gpt-5.2-codex to generate the translations. I only wrote the English text by hand and have not verified the text in other languages.