Update Polish localization strings for clarity by thesebas · Pull Request #29 · zjs81/meshcore-open

thesebas · 2026-01-12T15:29:34Z

No description provided.

zjs81

Thanks for improving the Polish translations! The terminology fixes (especially "rozgłoszenie" instead of "reklama") are correct for mesh networking context.

Issues to fix before merging:

Typo in app_localizations_pl.dart:

// Current (wrong):
String get repeater_cliHelpNeighbors =>
    'Wyświetla listę innych węzłów powtarzających się, które usłyszano dzięki rozgłszeniom zero-hop...';

// Should be (note the missing 'o' in rozgłoszeniom):
String get repeater_cliHelpNeighbors =>
    'Wyświetla listę innych węzłów powtarzających się, które usłyszano dzięki rozgłoszeniom zero-hop...';

Missing .arb file changes:

The source of truth for localizations is the .arb file. Please update lib/l10n/app_pl.arb with the same changes, then run:
```
flutter gen-l10n
```
This ensures the .arb and .dart files stay in sync and prevents your changes from being overwritten if someone regenerates the localization files.

446564 · 2026-02-01T04:11:25Z

@thesebas once changes are addressed please mark ready for review and we can get this in 😀

446564 · 2026-02-15T17:10:23Z

Are you still interested in working on this @thesebas

thesebas · 2026-02-18T18:11:26Z

Are you still interested in working on this @thesebas

Yes, thank you for checking this PR, pushed some more updates and executed requested arb/dart generation tasks.

Copilot

Pull request overview

This pull request updates Polish localization strings to improve clarity and accuracy. The main focus is replacing "reklama" (commercial advertisement) with "rozgłoszenie" (broadcast/announcement) throughout the mesh networking context, along with several other translation improvements and grammatical fixes.

Changes:

Replaced "reklama" with "rozgłoszenie" for mesh network broadcasts/advertisements (30+ occurrences)
Fixed spelling and grammar errors (e.g., "widiany" → "widziany", "odkryte" → "wykryte")
Improved technical terminology (e.g., "Rozkład Czynnika" → "Współczynnik rozpraszania", "Paski" → "kafelki")
Updated flood routing terminology from "Powodzie"/"Powódź" to "Zalew" for better clarity

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
lib/l10n/app_pl.arb	Updated Polish localization strings for clarity, replacing commercial advertisement terms with broadcast terminology and fixing spelling/grammar errors
lib/l10n/app_localizations_pl.dart	Auto-generated Dart localization file reflecting the .arb changes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

thesebas · 2026-02-18T18:39:35Z

Actually, I'm working on even more corrections; that batch was what I found in the app UI. Now I'm going label by label and trying to make it more consistent and use better wording. I'll add it to this PR if that's okay; otherwise, I'll prepare a separate one.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

thesebas · 2026-02-18T19:02:43Z

I'm unsure about translating those few technical terms (flood, repeater and route) but I think in Polish they sound more natural. If other users decide that it sounds unprofessional, they can always create a PR. :)

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

446564 · 2026-03-11T15:34:06Z

Sorry, merge conflicts have popped up. Then we can get this merged

thesebas · 2026-03-16T14:18:41Z

@446564 conflicts resolved, labels updated.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

thesebas · 2026-03-22T21:00:57Z

@446564 @zjs81 I've rebased it once more, fixed the new labels.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

zjs81 · 2026-03-24T01:40:30Z

Thanks I'll get it merged.

zjs81 reviewed Jan 13, 2026

View reviewed changes

446564 changed the title ~~Update Polish localization strings for clarity~~ WIP: Update Polish localization strings for clarity Feb 1, 2026

446564 marked this pull request as draft February 1, 2026 04:10

Copilot AI review requested due to automatic review settings February 18, 2026 18:10

Copilot started reviewing on behalf of thesebas February 18, 2026 18:11 View session

thesebas marked this pull request as ready for review February 18, 2026 18:11

Copilot AI reviewed Feb 18, 2026

View reviewed changes

446564 changed the title ~~WIP: Update Polish localization strings for clarity~~ Update Polish localization strings for clarity Feb 18, 2026

thesebas force-pushed the patch-1 branch from 72aa4aa to 08fa476 Compare February 18, 2026 18:54

Copilot AI review requested due to automatic review settings February 18, 2026 18:54

Copilot started reviewing on behalf of thesebas February 18, 2026 18:54 View session

Copilot AI reviewed Feb 18, 2026

View reviewed changes

Comment thread lib/l10n/app_pl.arb Outdated

thesebas requested review from Copilot and zjs81 February 18, 2026 19:03

thesebas force-pushed the patch-1 branch from 199afa5 to c6e5aaf Compare February 23, 2026 09:02

Copilot started reviewing on behalf of thesebas February 23, 2026 09:02 View session

Copilot AI reviewed Feb 23, 2026

View reviewed changes

thesebas force-pushed the patch-1 branch from c6e5aaf to b9fa7f6 Compare March 16, 2026 14:17

thesebas requested a review from Copilot March 16, 2026 14:19

Copilot started reviewing on behalf of thesebas March 16, 2026 14:21 View session

Copilot AI reviewed Mar 16, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings March 19, 2026 08:56

thesebas force-pushed the patch-1 branch from dc0e22c to 1c809a6 Compare March 19, 2026 08:59

thesebas added 7 commits March 22, 2026 21:51

Update Polish localization strings for consistency and clarity

5321974

Refactor code structure for improved readability and maintainability

532401c

Fix rebase merge error

35e296f

Some additional label adjustments

53cd3f4

fix missing labels

dc57f9b

fix plural form of the label

5140ff3

update new labels

bd03015

thesebas force-pushed the patch-1 branch from 3bff8fd to bd03015 Compare March 22, 2026 20:58

use correct word for repeater

7eff1df

Copilot AI review requested due to automatic review settings March 23, 2026 17:47

Copilot started reviewing on behalf of thesebas March 23, 2026 17:48 View session

Copilot AI reviewed Mar 23, 2026

View reviewed changes

Comment thread lib/l10n/app_pl.arb

Comment thread lib/l10n/app_pl.arb

Comment thread lib/l10n/app_pl.arb

use correct translation for Advert in another few places

5f475fc

thesebas requested a review from Copilot March 23, 2026 21:53

Copilot started reviewing on behalf of thesebas March 23, 2026 21:54 View session

Copilot AI reviewed Mar 23, 2026

View reviewed changes

Comment thread lib/l10n/app_pl.arb Outdated

Comment thread lib/l10n/app_localizations_pl.dart Outdated

thesebas added 2 commits March 23, 2026 23:07

make the 'lastSeen' labels shorter to not break the contacts list layout

9b1f1e1

some minor adjsts

f63bc4b

Copilot AI review requested due to automatic review settings March 23, 2026 22:11

Copilot started reviewing on behalf of thesebas March 23, 2026 22:12 View session

Copilot AI reviewed Mar 23, 2026

View reviewed changes

Comment thread lib/l10n/app_pl.arb

thesebas requested a review from Copilot March 23, 2026 22:20

Copilot started reviewing on behalf of thesebas March 23, 2026 22:20 View session

Copilot AI reviewed Mar 23, 2026

View reviewed changes

Comment thread lib/l10n/app_pl.arb

thesebas requested a review from Copilot March 23, 2026 22:23

Copilot started reviewing on behalf of thesebas March 23, 2026 22:34 View session

Copilot AI reviewed Mar 23, 2026

View reviewed changes

zjs81 merged commit da70d5f into zjs81:main Mar 24, 2026
9 of 12 checks passed

Conversation

thesebas commented Jan 12, 2026

Uh oh!

zjs81 left a comment

Choose a reason for hiding this comment

Uh oh!

446564 commented Feb 1, 2026

Uh oh!

446564 commented Feb 15, 2026

Uh oh!

thesebas commented Feb 18, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

thesebas commented Feb 18, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

thesebas commented Feb 18, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

446564 commented Mar 11, 2026

Uh oh!

thesebas commented Mar 16, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

thesebas commented Mar 22, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

zjs81 commented Mar 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants