Replace Publicité by Annonce in the french translations#28
Conversation
|
Thank you I will review this later today. |
zjs81
left a comment
There was a problem hiding this comment.
Thanks for improving the French translations! Replacing "publicité" with "annonce" is the correct semantic fix for mesh networking terminology.
Issues to fix before merging:
-
Typo in
app_localizations_fr.dartline 231:// Current (wrong): String get settings_sendAdvertisement => 'Envoyer l\'annnonce'; // Should be: String get settings_sendAdvertisement => 'Envoyer l\'annonce';
-
Mismatch between
.arband.dartfiles:The
.arbfile has:"settings_sendAdvertisement": "S'annoncer"
But the
.dartfile has:String get settings_sendAdvertisement => 'Envoyer l\'annnonce';
These should match. Either:
- Update the
.arbto"settings_sendAdvertisement": "Envoyer l'annonce", OR - Update the
.dartto'S\'annoncer'
Then run
flutter gen-l10nto regenerate and ensure they stay in sync. - Update the
|
Understood. That's my first confrontation with flutter, so I was surprised to have to change the translation twice (arb/dart files). It should be better now. |
Hi
I updated a few words in the french translations files to make them more understandable.
That's my first PR ever, so I haven't spent a lot of time on all the translations, I just want to see how it works.
Thanks again for your work.