Changed contacts latitude and longitude fields to be null until parsed and set#269
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates contact import/parsing so that missing GPS coordinates remain unset (null) instead of defaulting to 0,0, preventing contacts without location data from appearing at the equator/prime meridian.
Changes:
- Propagate
latitude/longitudewhen importing a discovered contact into the main contacts list. - Change advert/contact parsing locals from
doubledefaults (0.0) to nullabledouble?so absent location data staysnull.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes contact parsing so contacts without the location data don't get set to 0,0.