Dev guessed locations#264
Conversation
Adds map_showGuessedLocations and map_guessedLocation to app_en.arb and translates them across all 14 supported locales. Regenerates dart localizations.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7c479f9121
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b2770ef028
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| final lastHop = pathData.last; | ||
| final peers = connector.contacts |
There was a problem hiding this comment.
Use contact-side hop when inferring traced target location
When PathTraceMapScreen is opened with flipPathRound: true (as in the chat/path-management entry points added in this commit), pathData is a round-trip sequence, so pathData.last is on the local side rather than the target side. Inferring the target endpoint from this byte places the guessed target near the wrong repeater and then extends the polyline to that wrong endpoint, producing a misleading route map for these traces.
Useful? React with 👍 / 👎.
| final cacheKey = | ||
| '$filteredKeys|$anchorKeys|${pathHistory.version}:${connector.currentSf}:${connector.currentBwHz}:${connector.currentTxPower}:${settings.mapShowGuessedLocations}'; |
There was a problem hiding this comment.
Recompute guessed locations when contact routes or GPS change
This cache key is based on contact key lists and radio settings, but _computeGuessedLocations also depends on mutable per-contact route and location data (contact.path, and anchor latitude/longitude). If an existing contact's route or GPS changes without changing membership, _cachedGuessedLocations is reused and stale guessed markers remain until some unrelated key changes.
Useful? React with 👍 / 👎.
No description provided.