Dev map manage repeater#26
Conversation
|
This includes code from this PR #12 |
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| }, | ||
| ), | ||
| ); | ||
| } |
There was a problem hiding this comment.
Login dialog not dismissed after successful navigation
Medium Severity
The _showRepeaterLogin method shadows the context parameter with the builder's context, and the onLogin callback only calls Navigator.push without popping the RepeaterLoginDialog first. Since RepeaterLoginDialog doesn't close itself, the dialog remains in the navigation stack. When users navigate back from RepeaterHubScreen, they'll see the login dialog again instead of returning to the map. The callback needs to pop the dialog before pushing the new screen, but the variable shadowing makes this difficult to implement correctly.
|
A/B/C bounded pass shipped on branch
Deferred per this issue's opportunistic strategy (not swept — promote to its own issue when those files are next touched):
|
Add @wel97459 's changes along with some other fixes on his branch
Note
Enables managing repeater nodes directly from the map.
RepeaterLoginDialogflow and navigation toRepeaterHubScreenafter successful loginManage RepeaterforadvTypeRepeatercontactsrepeater_login_dialog.dartandrepeater_hub_screen.dartinmap_screen.dartWritten by Cursor Bugbot for commit 1ba3f3a. This will update automatically on new commits. Configure here.