Unify signal indicator UI across RSSI and SNR#246
Merged
Conversation
zjs81
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes signal-strength visuals consistent across the app by centralizing icon/color tier mapping and reusing it in both RSSI-based and SNR-based indicators.
Problem
Signal indicators were using different visual mappings in different components:
device_tile.dart) used one icon/color mapping.snr_indicator.dart) used a different mapping.This caused devices with similar quality to look different depending on screen/component.
Root Cause
Signal UI mapping logic was duplicated in multiple widgets with diverging icon/color choices.
Fix
lib/widgets/signal_ui.dart.lib/widgets/device_tile.dartto use shared tiers.lib/widgets/snr_indicator.dartto use shared tiers.Screenshot
Validation
flutter build apk --debugpasses on this PR branch.Issue
Fixes #245