Skip to content

feat: hide message tracing#216

Merged
zjs81 merged 7 commits into
zjs81:mainfrom
MeshEnvy:feat/hide-message-tracing
Feb 23, 2026
Merged

feat: hide message tracing#216
zjs81 merged 7 commits into
zjs81:mainfrom
MeshEnvy:feat/hide-message-tracing

Conversation

@benallfree

@benallfree benallfree commented Feb 22, 2026

Copy link
Copy Markdown
Contributor

This PR introduces a more compact version of messages.

Closes #97

image image
2026-02-22_11-25-08.mp4

@wel97459

Copy link
Copy Markdown
Collaborator

I would like to see the setting moved into the chat settings dialog. along with adding a button and dialog for the channels.

@benallfree

benallfree commented Feb 22, 2026

Copy link
Copy Markdown
Contributor Author

@wel97459 How do I find the chat settings dialog? Not sure where that one is.

Where would the button go for channels?

Comment thread lib/screens/channel_chat_screen.dart Outdated
Comment thread lib/screens/channel_chat_screen.dart Outdated
borderRadius: BorderRadius.circular(12),
child: GifMessage(
url:
'https://media.giphy.com/media/$gifId/giphy.gif',

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code shouldnt be in here. We should be using the gif widget helpers.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that it was before but we should move it to clean it up.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually try to keep refactoring PRs separate but I'll do it here if you have a strong opinion. I think the chat/channel_chat could benefit from a more thorough widget refactoring later, we could hit it there too.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is fine we can refactor it later

@zjs81

zjs81 commented Feb 22, 2026

Copy link
Copy Markdown
Owner

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 35498c1b90

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread lib/screens/chat_screen.dart
Comment thread lib/screens/channel_chat_screen.dart
@benallfree

Copy link
Copy Markdown
Contributor Author

Thanks for all the feedback. I’ll circle back later tonight or tomorrow. On the road to Elko NV to help them get their mesh set up.

The gray cloud - was looking for a way to indicate hears by 0 repeaters (gray cloud/busy) vs >=1 (green check). Just something to indicate that it hit at least 1 repeater. I’m not quite sure when to consider a message sent except maybe >=1 ack.

@zjs81

zjs81 commented Feb 23, 2026

Copy link
Copy Markdown
Owner

Thanks for all the feedback. I’ll circle back later tonight or tomorrow. On the road to Elko NV to help them get their mesh set up.

The gray cloud - was looking for a way to indicate hears by 0 repeaters (gray cloud/busy) vs >=1 (green check). Just something to indicate that it hit at least 1 repeater. I’m not quite sure when to consider a message sent except maybe >=1 ack.

Oh sweet good luck out there. That makes sense I think maybe an empty check box would make more sense or something we can think about it.

@benallfree

benallfree commented Feb 23, 2026

Copy link
Copy Markdown
Contributor Author

New look @wel97459 @zjs81 thoughts?

To me the difference is not as visible without a badge background.

image
2026-02-23_04-17-59.mp4

@ChaoticLeah

Copy link
Copy Markdown
Contributor

I assume the checks show that it has seen at least 1 relay. I can hardly see the difference in color and for people with color blindness this is even more of an issue. Ontop of the color could we have 1 check mark for sent, and 2 for when we have heard an echo?

@zjs81 zjs81 merged commit 64bf307 into zjs81:main Feb 23, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Compact Chat Layout

4 participants