Handle RESP_CODE_ERR frames explicitly in connector#182
Merged
Conversation
Port from meshcore-open: parse protocol version from byte 1 of device info frame, expose supportsFloodScope getter (version >= 8), handle respCodeErr frames with debug logging. Reset on disconnect. Co-authored-by: Cursor <cursoragent@cursor.com> (cherry picked from commit a29bb9c)
446564
reviewed
Feb 18, 2026
446564
reviewed
Feb 18, 2026
446564
requested changes
Feb 18, 2026
Contributor
Author
|
Follow-up update based on review: I narrowed this PR to one incremental change only: explicit RESP_CODE_ERR handling in MeshCoreConnector with protocol-tagged logging. Removed from this PR:
Current diff vs main is limited to lib/connector/meshcore_connector.dart and focused on error-frame routing/logging. Validation rerun after narrowing:
|
446564
approved these changes
Feb 18, 2026
446564
left a comment
Collaborator
There was a problem hiding this comment.
Nice and clean. In future for changes that do not have an existing issue, can you please open one to discuss what may be needed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
RESP_CODE_ERR(protocol response code1) was falling through to the generic "unknown frame" path in the connector, which loses structured firmware error detail.Solution
respCodeErrbranch in_processFrame_appDebugLogService?.warn(..., tag: 'Protocol')Scope
This PR is intentionally limited to connector error-frame handling in:
lib/connector/meshcore_connector.dartNot included in this PR:
Validation
flutter analyzepassesflutter testpasses