Add path tracing functionality to map screen by wel97459 · Pull Request #165 · zjs81/meshcore-open

wel97459 · 2026-02-12T20:14:01Z

Implemented path tracing feature in the map screen, allowing users to add nodes to a path and visualize it on the map as they select nodes.
Added buttons for starting path tracing, removing the last node, and running the path trace.
Introduced a new overlay to display current path information and distance.
Updated localization files for multiple languages to include new strings related to path tracing.
Refactored map rendering logic to accommodate path tracing visuals.

- Implemented path tracing feature in the map screen, allowing users to add nodes to a path and visualize it on the map. - Added buttons for starting path tracing, removing the last node, and running the path trace. - Introduced a new overlay to display current path information and distance. - Updated localization files for multiple languages to include new strings related to path tracing. - Refactored map rendering logic to accommodate path tracing visuals.

Copilot

Pull request overview

Adds an in-map “path trace” builder workflow so users can select nodes on the main map, visualize the selected path, and then run an actual trace in the dedicated Path Trace screen. Also updates localization resources to support new UI strings.

Changes:

Add path-building mode to MapScreen (select nodes to build a path, show overlay, run trace).
Refactor PathTraceMapScreen map rendering and distance formatting utilities.
Update ARB + generated localization files with new path-tracing strings (and remove some duplicate entries).

Reviewed changes

Copilot reviewed 33 out of 33 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
lib/screens/path_trace_map.dart	Extracts distance helpers, refactors map widget build, improves unknown-hop labeling, adds additional error handling.
lib/screens/map_screen.dart	Adds path-building mode, overlay UI (tap-to-add, remove last, run trace), and polyline rendering during path build.
lib/l10n/app_en.arb	Adds new strings for map path building + clear tooltip.
lib/l10n/app_de.arb	Adds new strings; also removes duplicate entries/normalizes formatting.
lib/l10n/app_es.arb	Adds new strings; also removes duplicate entries/normalizes formatting.
lib/l10n/app_fr.arb	Adds new strings for map path building.
lib/l10n/app_it.arb	Adds new strings for map path building.
lib/l10n/app_nl.arb	Adds new strings for map path building.
lib/l10n/app_pl.arb	Adds new strings for map path building.
lib/l10n/app_pt.arb	Adds new strings for map path building.
lib/l10n/app_ru.arb	Adds new strings for map path building.
lib/l10n/app_sk.arb	Adds new strings for map path building.
lib/l10n/app_sl.arb	Adds new strings for map path building.
lib/l10n/app_sv.arb	Adds new strings for map path building.
lib/l10n/app_uk.arb	Adds new strings for map path building.
lib/l10n/app_zh.arb	Adds new strings for map path building.
lib/l10n/app_bg.arb	Adds new strings for map path building.
lib/l10n/app_localizations.dart	Adds new localization getters for map path-building + clear tooltip.
lib/l10n/app_localizations_en.dart	Implements new localization getters.
lib/l10n/app_localizations_de.dart	Implements new localization getters.
lib/l10n/app_localizations_es.dart	Implements new localization getters.
lib/l10n/app_localizations_fr.dart	Implements new localization getters.
lib/l10n/app_localizations_it.dart	Implements new localization getters.
lib/l10n/app_localizations_nl.dart	Implements new localization getters.
lib/l10n/app_localizations_pl.dart	Implements new localization getters.
lib/l10n/app_localizations_pt.dart	Implements new localization getters.
lib/l10n/app_localizations_ru.dart	Implements new localization getters.
lib/l10n/app_localizations_sk.dart	Implements new localization getters.
lib/l10n/app_localizations_sl.dart	Implements new localization getters.
lib/l10n/app_localizations_sv.dart	Implements new localization getters.
lib/l10n/app_localizations_uk.dart	Implements new localization getters.
lib/l10n/app_localizations_zh.dart	Implements new localization getters.
lib/l10n/app_localizations_bg.dart	Implements new localization getters.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-12T20:20:57Z

 import 'package:latlong2/latlong.dart';
+import 'package:meshcore_open/screens/path_trace_map.dart';
 import 'package:provider/provider.dart';


map_screen.dart imports path_trace_map.dart just to reuse getPathDistanceMeters / formatDistance. This introduces an unnecessary dependency on a UI screen file and makes reuse harder. Consider moving these helpers into a small shared utility (e.g., lib/utils/path_distance.dart) and importing that instead.

This is not true there is a navigation to PathTraceMapScreen method.

Copilot · 2026-02-12T20:20:58Z

+        _polylines.clear();
+        _polylines.addAll(
+          _points.length > 1
+              ? [
+                  Polyline(


build() is mutating state by clearing/rebuilding _polylines on every rebuild. This makes the widget harder to reason about and can lead to subtle issues if build is triggered often. Prefer deriving a local final polylines = ... from _points (without mutating state), or update _polylines only inside setState when _points changes.

Copilot · 2026-02-12T20:20:58Z

+      _pathTrace.add(
+        contact.publicKey[0],
+      ); // Add first 16 bytes of public key to path trace
+      _points.add(LatLng(contact.latitude!, contact.longitude!));


The inline comment says “Add first 16 bytes of public key”, but the code only appends contact.publicKey[0] (1 byte). Please correct the comment to match the actual behavior (or adjust the logic if the intent really is 16 bytes).

Copilot · 2026-02-12T20:20:58Z

+  /// No description provided for @pathTrace_clearTooltip.
+  ///
+  /// In en, this message translates to:
+  /// **'Clear path.'**
+  String get pathTrace_clearTooltip;
+


pathTrace_clearTooltip is added to localizations, but it is not referenced anywhere in the Dart codebase. Either wire this up to the intended UI (e.g., a clear-path action/tooltip) or remove the string to avoid unused translations and translator churn.

Suggested change

/// No description provided for @pathTrace_clearTooltip.

///

/// In en, this message translates to:

/// **'Clear path.'**

String get pathTrace_clearTooltip;

zjs81 · 2026-02-12T21:03:39Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c1afd6c9a8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-02-12T21:10:19Z

+                          MaterialPageRoute(
+                            builder: (context) => PathTraceMapScreen(
+                              title: l10n.contacts_pathTrace,
+                              path: Uint8List.fromList(_pathTrace),


Enforce max trace path length before sending request

The selected path is passed straight through as Uint8List.fromList(_pathTrace) with no size check, so users can keep adding nodes until the trace payload exceeds the protocol frame budget (trace header + payload, with frames capped at 172 bytes). In larger meshes this can produce oversized trace requests that are rejected or truncated by the device transport; add a guard and user feedback before allowing/sending paths beyond the supported length.

Useful? React with 👍 / 👎.

@codex fix this

To use Codex here, create an environment for this repo.

@codex address that feedback

Summary

Added explicit frame-budget constants in MapScreen so path trace payload sizing is derived from protocol max frame size (172) minus trace request overhead ([cmd][tag x4][auth x4][flag]). lib/screens/map_screen.dartL48-L51 lib/connector/meshcore_protocol.dartL220 lib/connector/meshcore_protocol.dartL741-L750

Added a guard in _addToPath to stop adding nodes when the trace path reaches the supported payload limit, and show user feedback via SnackBar instead of allowing an oversized request path to be built. lib/screens/map_screen.dartL1456-L1466

Added a defensive guard before launching PathTraceMapScreen to prevent sending if path length is oversized, with snackbar feedback for the user. lib/screens/map_screen.dartL1530-L1540 lib/screens/map_screen.dartL1542-L1549

Corrected the stale inline comment to reflect the actual behavior (1-byte public key hash prefix, not 16 bytes). lib/screens/map_screen.dartL1469-L1472

Committed changes as 08cc9b0 and created a follow-up PR via the make_pr tool.

Testing

✅ git diff -- lib/screens/map_screen.dart

✅ git status --short

⚠️ ~/flutter/bin/dart format lib/screens/map_screen.dart (Flutter/Dart SDK path unavailable in this environment: /root/flutter/bin/dart not found)

View task →

chatgpt-codex-connector · 2026-02-12T21:10:19Z

+          onLongPress: () =>
+              _isBuildingPathTrace ? _showNodeInfo(context, contact) : null,


Avoid swallowing long-presses when path mode is off

This always installs a marker onLongPress callback, but when _isBuildingPathTrace is false the callback just returns null. That still captures long-press gestures on top of markers, so map-level long-press behavior (like the share-marker flow on the map) no longer triggers in those spots. Make the handler itself null when path tracing is inactive instead of returning null from an active handler.

Useful? React with 👍 / 👎.

@codex fix this

To use Codex here, create an environment for this repo.

@codex address that feedback

Summary

Updated marker long-press wiring in MapScreen so GestureDetector.onLongPress is only assigned when _isBuildingPathTrace is active; otherwise it is null. This prevents markers from swallowing long-press gestures when path tracing is off while preserving the path-mode behavior. lib/screens/map_screen.dartL468-L474

Committed the change with message: Fix marker long-press handler in path mode (commit 4aa2e05), and created a follow-up PR via the make_pr tool.

Testing

⚠️ python - <<'PY' ... urllib.request.urlopen('https://api.github.com/search/issues?q=flutter+GestureDetector+onLongPress') ... PY (web-search attempt failed due network tunnel restriction: 403 Forbidden).

⚠️ ~/flutter/bin/flutter analyze lib/screens/map_screen.dart (Flutter binary not present at that path in this environment).

⚠️ flutter --version (command not found in environment).

View task →

446564 · 2026-02-12T21:37:45Z

tested and working well other than above changes

446564

lgtm

Copilot AI review requested due to automatic review settings February 12, 2026 20:14

Copilot started reviewing on behalf of wel97459 February 12, 2026 20:14 View session

Copilot AI reviewed Feb 12, 2026

View reviewed changes

chatgpt-codex-connector Bot reviewed Feb 12, 2026

View reviewed changes

Merge branch 'main' into dev-NewPathTracing

39b544f

446564 approved these changes Feb 14, 2026

View reviewed changes

zjs81 merged commit 7308186 into main Feb 14, 2026
6 checks passed

wel97459 deleted the dev-NewPathTracing branch March 7, 2026 09:51

		onLongPress: () =>
		_isBuildingPathTrace ? _showNodeInfo(context, contact) : null,

Conversation

wel97459 commented Feb 12, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

wel97459 Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

zjs81 commented Feb 12, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

zjs81 Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

zjs81 Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Feb 12, 2026

Choose a reason for hiding this comment

Summary

Uh oh!

chatgpt-codex-connector Bot Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

zjs81 Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

zjs81 Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Feb 12, 2026

Choose a reason for hiding this comment

Summary

Uh oh!

446564 commented Feb 12, 2026

Uh oh!

446564 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants